fix: Downgrade passport back to 0.5.3 #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
|
So we can't test this on the Pizza as it auths against the staging API. If we're happy can we merge this and test on staging? |
jessicamcinchak
approved these changes
Jul 26, 2022
gunar
added a commit
that referenced
this pull request
Jul 28, 2022
…mains # By Jessica McInchak (11) and Dafydd Llŷr Pearson (10) # Via GitHub * origin/main: (21 commits) chore: Upgrade Editor dependencies (Part 1) (#1047) chore: upgrade metabase (#1050) fix: Drop sslPolicy for HTTP (#1051) chore(infra): Update HTTP/HTTPS listener SSL policy (#1049) chore: Enable Save and Return by default (#1048) fix: add single line address as separate CSV row (#1046) feat: Enable emailReplyToID (#1044) fix: Display ContentPage on Save and Return path (#1045) chore: upgrade scripts/seed-database dependencies (#1043) chore: upgrade e2e test dependencies (#1042) fix: adjust HASURA_GRAPHQL_CORS_DOMAIN in pulumi (#1041) fix: preserve breadcrumb order when reconciling changed content (#1034) fix: restrict a user from drawing a site boundary and uploading a location plan (#1040) feat: Apply basic rate limiting to API (#1038) fix: use HASURA_GRAPHQL_CORS_DOMAIN env variable to whitelist domains (#1039) fix: Downgrade passport back to 0.5.3 (#1037) chore: Update Hasura (#1035) build: Upgrade API dependencies (#1033) chore: remove Uniform feature flag (#1027) fix: Review page shows all DrawBoundary data (map and/or plan) and file gets correct BOPS tag (#1030) ... # Conflicts: # editor.planx.uk/package.json # editor.planx.uk/pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoes changes made in this commit - 22dad6c
Issue described here - jaredhanson/passport#904
Initially I thought this was a conflict caused by cookie-session v2, which is maybe not the cause of the issue. I'll separately try to update that and test. Discussion here that triggered this belief...! jaredhanson/passport#907
We'll have to keep an eye on this one as there is a CVE associated with this package/version (I'll maybe add to Slack for now like Hasura until we sort out dependabot?). There is an override in the
package.jsonwhich should keep up on the safe side here however so no immediate worries 👍To test...