Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme: Button component #130

Closed
rluders opened this issue May 17, 2022 · 1 comment · Fixed by #160
Closed

Theme: Button component #130

rluders opened this issue May 17, 2022 · 1 comment · Fixed by #160
Assignees
@tulup-conner
Labels
good first issue Good for newcomers 🚀 enhancement New feature or request

Comments

@rluders
Copy link
Collaborator

rluders commented May 17, 2022

Is your feature request related to a problem? Please describe.
Improve the theme support to the component (and subcomponents).

Describe the solution you'd like

  • All default styles must be moved to the default theme;

Describe alternatives you've considered
n/a

Additional context
n/a
@rluders rluders added 🚀 enhancement New feature or request good first issue Good for newcomers labels May 17, 2022
@tulup-conner
Copy link
Collaborator

Gimme this

tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 27, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
496d6a6 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 27, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
4ceac84 
…erg#130
@tulup-conner tulup-conner mentioned this issue May 27, 2022
Merged
7 tasks
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 27, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
1503c72 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 27, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
5b9a5cf 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 27, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
9f4c74f 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 27, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
d969627 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 28, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
61f5975 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 28, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
442aaca 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 28, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
367e73e 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue May 31, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
f30ec5e 
…erg#130
@rluders rluders added this to the v1.0.0-alpha milestone Jun 2, 2022
@rluders rluders linked a pull request Jun 2, 2022 that will close this issue
feature(component): Rewrite Buttons to use themes, resolves #130 #160
Merged
7 tasks
@rluders rluders moved this from Backlog to In Progress in Flowbite React Development Jun 2, 2022
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jun 3, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
d6a598e 
…erg#130
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jun 3, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves themesb…
38c7a68 
…erg#130
rluders pushed a commit that referenced this issue Jun 3, 2022
@tulup-conner
feature(component): Rewrite Buttons to use themes, resolves #130 (#160
9055aa8 
)

* feature(type): Add theme for `Button`s

* feature(component): Rewrite `Button`s to use themes, resolves #130

* test(component): Add numerous unit tests for `Button`s

* test(helper): Update `mergeDeep` unit tests for real use cases

Now that we are actually using `mergeDeep` for
`<Flowbite theme={..}>`, I wanted to update this
spec to more accurately reflect the use cases we
need to solve.

* feature(type): Add theme for `Button.Group`s

* feature(component): Rewrite `Button.Group` to use theme

* test(component): Add numerous unit tests for `Button.Group`s

* refactor(type): Move `Button` style edge case to theme

The combination of `outline={true}` and `color="gray"`
triggers a set of special classes. So I set up the
API like so:

```js
outline: {
  base: '..',
  color: {
    gray: 'special case classes',
    ... any other special cases the user may need to accomodate
  },
  ..
}
```
Repository owner moved this from In Progress to Done in Flowbite React Development Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tulup-conner tulup-conner

Labels
good first issue Good for newcomers 🚀 enhancement New feature or request
Projects
Flowbite React Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(component): Rewrite Buttons to use themes, resolves #130 tulup-conner/flowbite-react
2 participants
@rluders @tulup-conner