-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(component): Rewrite Button
s to use themes, resolves #130
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulup-conner
force-pushed
the
feature/buttons-theme
branch
8 times, most recently
from
May 28, 2022 05:17
df435c7
to
159cab8
Compare
tulup-conner
force-pushed
the
feature/buttons-theme
branch
from
May 28, 2022 05:39
fc3bc98
to
ed3ca4f
Compare
tulup-conner
force-pushed
the
feature/buttons-theme
branch
from
May 28, 2022 23:01
ed3ca4f
to
9140a24
Compare
rluders
requested changes
May 29, 2022
tulup-conner
force-pushed
the
feature/buttons-theme
branch
from
May 31, 2022 06:59
9140a24
to
719c9bb
Compare
Closed
tulup-conner
force-pushed
the
feature/buttons-theme
branch
from
June 3, 2022 00:16
719c9bb
to
4ef5b9c
Compare
Now that we are actually using `mergeDeep` for `<Flowbite theme={..}>`, I wanted to update this spec to more accurately reflect the use cases we need to solve.
The combination of `outline={true}` and `color="gray"` triggers a set of special classes. So I set up the API like so: ```js outline: { base: '..', color: { gray: 'special case classes', ... any other special cases the user may need to accomodate }, .. } ```
tulup-conner
force-pushed
the
feature/buttons-theme
branch
from
June 3, 2022 00:23
4ef5b9c
to
13f3cf4
Compare
rluders
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Button
s andButton.Group
s can now be customized using<Flowbite theme={..}>
.Features
Tests
Unit