Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rootless podman support #6158

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

SoMuchForSubtlety
Copy link
Contributor

@SoMuchForSubtlety SoMuchForSubtlety commented Nov 9, 2022

Follow-up for #5822 with a new CI check for podman.

Open Issues

@SoMuchForSubtlety SoMuchForSubtlety requested a review from a team as a code owner November 9, 2022 12:40
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Nov 9, 2022
@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 0dedfbe to 174e350 Compare November 9, 2022 12:45
@eddumelendez
Copy link
Member

@SoMuchForSubtlety thanks again for submitting a PR! However, Podman support should not alter the current tests.

@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 0f56dfa to f565283 Compare November 9, 2022 15:30
@SoMuchForSubtlety
Copy link
Contributor Author

@SoMuchForSubtlety thanks again for submitting a PR! However, Podman support should not alter the current tests.

I reverted the test changes and skip them instead.

build.gradle Outdated Show resolved Hide resolved
@SoMuchForSubtlety
Copy link
Contributor Author

SoMuchForSubtlety commented Nov 10, 2022

I'll try to get the outstanding compatibility issues fixed in podman. I would be grateful if this PR could stay open to track the progress.

Would it be OK to fix a (probable) bug in the tests?

// push the image to the registry
client.tagImageCmd(dummyImageId, imageName.asCanonicalNameString(), tag).exec();

imageName.asCanonicalNameString() returns the image name with the tag, so for example localhost:123/my-image:1.0.0, but tagImageCmd takes the image tag as a separate parameter, so the end result would be localhost:123/my-image:1.0.0:1.0.0.
This should probably be client.tagImageCmd(dummyImageId, imageName.getUnversionedPart(), tag).exec();.

According to the docker API spec, the repo parameter should not contain a tag.

@kiview
Copy link
Member

kiview commented Nov 11, 2022

Thanks a lot for your work on this PR and your openness to collaboration @SoMuchForSubtlety, this is much appreciated. We can of course keep the PR open to track the progress.

Regarding:

Would it be OK to fix a (probable) bug in the tests?

Of course, maybe even better as a small distinct PR, to decouple it from the Podman development work (since it is indeed independent of it).

@SoMuchForSubtlety
Copy link
Contributor Author

SoMuchForSubtlety commented Apr 14, 2023

Podman 4.5.0 with the last required fix landed today, this is ready for review 🙂

@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 7205750 to 2321321 Compare April 14, 2023 21:23
@pan3793
Copy link
Contributor

pan3793 commented Apr 18, 2023

Does it work w/ docker compose?

@SoMuchForSubtlety
Copy link
Contributor Author

Does it work w/ docker compose?

No, because testcontainers currently uses the deprecated link feature for the compose ambassador container. If/when the implementation is changed to not use links, it should work, but that is out of scope for this PR.

@pan3793
Copy link
Contributor

pan3793 commented Apr 19, 2023

Got it, thanks @SoMuchForSubtlety

@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from f1bd0fa to d1926a6 Compare April 25, 2023 14:25
@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 3 times, most recently from 9a7b3ec to 7b59893 Compare May 15, 2023 07:46
@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 65a53e6 to 9b70281 Compare May 24, 2023 16:03
@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 4bd4287 to 80ad983 Compare June 1, 2023 07:21
@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 295a8e6 to 394f812 Compare June 9, 2023 12:41
@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 65cc501 to c565edf Compare June 22, 2023 21:12
@SoMuchForSubtlety SoMuchForSubtlety force-pushed the podman-support branch 2 times, most recently from 6fa1da4 to ca94c0b Compare July 30, 2023 00:07
@SoMuchForSubtlety
Copy link
Contributor Author

This PR has been ready for a while now, any change of getting a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client/podman github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants