api: remove unmapped ports from PortBindings

[SoMuchForSubtlety]

The docker API doesn't list exposed, but unmapped ports in HostConfig.PortBindings. Podman lists them with a value of null. This PR changes this behaviour to also omit them completely.

This is required for testcontainers/testcontainers-java#6158

Does this PR introduce a user-facing change?

None

[rhatdan]

For some reason the DCO check is failing.

Could you do a

git commit -a --amend -s
git push --force

To see if clears up the test.

[rhatdan]

@mheon @vrothberg @Luap99 PTAL

[Luap99]

I added this a while ago, according to #10777 docker displays null, I guess the difference is that it does not display the port when the container is not running?

[SoMuchForSubtlety]

I guess the difference is that it does not display the port when the container is not running?

I don't think that that's the case. You can see the full test here. The container is running when the host config port bindings get checked.

I did not start the container in the test I added because I didn't think that it made a difference.

[Luap99]

Ok I see it now there are different port fileds, there is HostConfig.PortBindings but also NetworkSettings.Ports. The later will show exposed ports with null. So your patch is ok but it would only effect the API level.
Looking at docker they show the exposed ports under Config.ExposedPorts, I think we should match that and instead remove the exposed port from the HostConfig.PortBindings field. This should then allow the compat API to just work without extra changes.

[Luap99]

code LGTM, can you squash your commits please?

[SoMuchForSubtlety]

code LGTM, can you squash your commits please?

done 🙂

[mheon]

/lgtm
/hold

[rhatdan]

/approve
/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, SoMuchForSubtlety

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment