Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Feature and FeatureCollection support to implement geometry normalization #4126

Merged
merged 6 commits into from
May 18, 2022
Merged

FIX Feature and FeatureCollection support to implement geometry normalization #4126

merged 6 commits into from
May 18, 2022

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented May 18, 2022 •
edited
Loading

Final fixes for issue #4114

  • cleantup
  • doc
  • test in real use case

@fgalan
Copy link
Member Author

fgalan commented May 18, 2022

test in real use case

Confirmed by @pelayogb

@fgalan fgalan changed the title [WIP] FIX Feature and FeatureCollection support to implement geometry normalization FIX Feature and FeatureCollection support to implement geometry normalization May 18, 2022
@fgalan fgalan requested a review from mapedraza May 18, 2022 11:09
mapedraza
mapedraza approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit 169b5b1 into master May 18, 2022
@mapedraza mapedraza deleted the feature/4114_geojson_feature_support_fixes branch May 18, 2022 12:25
@fgalan fgalan mentioned this pull request May 18, 2022
Closed
@fgalan
Copy link
Member Author

fgalan commented May 18, 2022

@fisuda this PR modifies one of the .md documentation files. In fact, the modifications are build upon the ones in PR #4116, which was merged before this one.

It would be great if you could sync the Japanese translation with the new version of the .md file, please. Thanks!

@pelayogb
Copy link
Collaborator

pelayogb commented May 18, 2022 •
edited
Loading

La prueba realizada combina dos tipos de widgets, basic-map y detail, en una funcionalidad concreta, crear una entidad a partir de la geolocalización, con destino y origen el CB.
Pasos seguidos en el panel de activos:

  1. Se selecciona una ubicación en el widget de tipo basic-map. De esta ubicación se manda la localización en formato geometry con Features.
  2. Desde el detail se cumplimentan los campos obligatorios y se guarda la entidad.

Resultado: el geometry con Features se transforma, se guarda correctamente en el CB (destino) y se visualiza correctamente en el mapa y en el detail (sin Features). Prueba OK

fisuda added a commit to fisuda/fiware-orion that referenced this pull request May 19, 2022
@fisuda
(JP) Add doc about Feature and FeatureCollection support (telefonicai…
384a851 
…d#4126)
@fisuda
Copy link
Contributor

fisuda commented May 19, 2022

I send the PR #4128. Thanks.

fgalan added a commit that referenced this pull request May 19, 2022
@fgalan
Merge pull request #4128 from fisuda/patch
1af7c7c 
(JP) Add doc about Feature and FeatureCollection support (#4126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapedraza mapedraza mapedraza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgalan @pelayogb @fisuda @mapedraza