Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoJSON Feature support #4114

Closed
fgalan opened this issue May 9, 2022 · 5 comments
Closed

GeoJSON Feature support #4114

fgalan opened this issue May 9, 2022 · 5 comments
Labels
Milestone

Comments

@fgalan
Copy link
Member

fgalan commented May 9, 2022

Is your feature request related to a problem / use case? Please describe.

Orion doesn't support valid GeoJSON as this one (can be checked here:

{
    "type": "Feature",
    "geometry": {
        "type": "Point",
        "coordinates": [
            -3.6127119138731127,
            40.53901978067972
        ]
    },
    "properties": {
        "label": "-3.6127119138731127, 40.53901978067972"
    }
}

given that is a Feature and MongoDB doesn't support that type and a 500 Internal Error response results in that case.

Describe the solution you'd like

The structure of the Feature GeoJSON is fixed, so it would be easy for Orion to move directly the geometry field to the location fiedl in the DB where the geo index is built

Describe alternatives you've considered

User can use ignoreType metadata to support that case, but the geo-location of the entity will be lost (i.e. a query query covering will not work).

Describe why you need this feature

  • To approach a new use case.
  • To improve or simplify an scenario.

Do you have the intention to implement the solution

  • Yes, I have the knowledge to implement this new feature.
@fgalan fgalan added the backlog label May 9, 2022
@fgalan fgalan added this to the 3.7.0 milestone May 9, 2022
@fgalan
Copy link
Member Author

fgalan commented May 9, 2022

FeaturesCollection type should be also supported:

  • If only has one element, takes the geometry of such first element
  • If has more than one element, return error

@fgalan
Copy link
Member Author

fgalan commented May 12, 2022

PR #4116

@fgalan
Copy link
Member Author

fgalan commented May 18, 2022

Extra PR #4126, changing the retrieval logic, based in internal discussions.

@fgalan
Copy link
Member Author

fgalan commented May 19, 2022

Extra PR #4129 to support ignoreType in the new geo:json types

@fgalan
Copy link
Member Author

fgalan commented May 25, 2022

Extra PR #4139 fixing some ignoreType support gaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant