ADD GeoJSON Feature type support #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
commented
May 12, 2022
Comment on lines
-169
to
-174
| // If attribute value is not null, then it has to be object in this case | ||
| if ((caP->valueType != orion::ValueTypeNull) && ((caP->compoundValueP == NULL) || !(caP->compoundValueP->isObject()))) | ||
| { | ||
| *errDetail = "geo:json needs an object or null as value"; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Moved to checkGeoJson() in the parsing layer. Seems to be a more proper place.
NTC (informative)
fgalan
changed the title
|
@fisuda this PR modifies some .md files. It would be great if you could update the Japanese translation also, please. Thanks! |
3 tasks
|
I'm sorry. I overlooked this message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4114