Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HorizontalPodAutoscaler v2beta1 is deprecated in v1.22+ #5128

Closed
Ijmcclung opened this issue Jul 12, 2022 · 8 comments · Fixed by #5130
Closed

HorizontalPodAutoscaler v2beta1 is deprecated in v1.22+ #5128

Ijmcclung opened this issue Jul 12, 2022 · 8 comments · Fixed by #5130
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Pipelines v0.41

Comments

@Ijmcclung
Copy link

Expected Behavior

A released deployment manifest that does not use the deprecated HorizontalPodAutoscaler.

Actual Behavior

tekton-pipelines uses HorizontalPodAutoscaler in the deployment manifest

Steps to Reproduce the Problem

  1. Download latest release yaml or v0.27.3 yaml

Additional Info

  • Kubernetes version: 1.23

  • tkn version :
    Pipeline version: v0.27.3
    Triggers version: v0.16.0
    Dashboard version: v0.20.0

  • Full warning: autoscaling/v2beta1 HorizontalPodAutoscaler is deprecated in v1.22+, unavailable in v1.2
    5+; use autoscaling/v2 HorizontalPodAutoscaler
@Ijmcclung Ijmcclung added the kind/bug Categorizes issue or PR as related to a bug. label Jul 12, 2022
@Ijmcclung Ijmcclung changed the title HorizontalPodAutoscaler is deprecated in v1.22+ HorizontalPodAutoscaler v2beta1 is deprecated in v1.22+ Jul 12, 2022
@vdemeester vdemeester mentioned this issue Jul 13, 2022
Merged
7 tasks
@vdemeester
Copy link
Member

From #5130

Alright, this fails because apiVersion: autoscaling/v2, kind: HorizontalPodAutoscaler is available starting with 1.23. So v2beta1 is, weirdly enough, deprecated in 1.22+ but the v2 is only available in 1.23.

Bumping to autoscaling/v2 would effectively mean we require a minimum version of kubernetes to be 1.23. We, most likely, will have to do this before or at the same time as kubernetes 1.25 goes out or is "widely" available.

See https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/ and https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/

@abayer
Copy link
Contributor

abayer commented Aug 10, 2022

/priority important-soon

Since we haven't even yet moved to k8s 1.22 minimum, I don't think we can bump straight to 1.23 in v0.39. Maybe v0.40?

@tekton-robot tekton-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 10, 2022
@abayer abayer added this to the Pipelines v0.40 milestone Aug 23, 2022
@pritidesai
Copy link
Member

Can we start testing on 1.23 and record any outstanding items?

@pritidesai
Copy link
Member

/cc @pritidesai

@abayer
Copy link
Contributor

abayer commented Aug 23, 2022

Related knative/serving issue - knative/serving#12806. Looks like Knative will be moving to k8s 1.23 as minimum version in October: https://github.com/knative/community/blob/main/mechanics/RELEASE-SCHEDULE.md. Whether that's a blocker for us moving to requiring 1.23, I don't know.

@pritidesai
Copy link
Member

We can test but I am thinking it could be a blocker

@pritidesai
Copy link
Member

@dprotaso mentioned 1.23 is not in GKE regular channel - knative/community#1140 😞

@pritidesai
Copy link
Member

pritidesai commented Aug 23, 2022 •
edited
Loading

Since we haven't even yet moved to k8s 1.22 minimum, I don't think we can bump straight to 1.23 in v0.39. Maybe v0.40?

I thought the minimum was already 1.22 but that's not the case as per our documentation. But the default minimum version needed for knative is 1.22 as per https://github.com/tektoncd/pipeline/blob/main/vendor/knative.dev/pkg/version/version.go#L36 And the PR - #4928.

I missed this action-required in the release notes 😞

@goern goern mentioned this issue Sep 5, 2022
Closed
Repository owner moved this from Todo to Done in Tekton Community Roadmap Oct 31, 2022
olegTarassov added a commit to olegTarassov/terraform-aws-eks-blueprints that referenced this issue May 17, 2023
@olegTarassov
Bump Kubecost version
1f4d095 
EKS version 1.25+ breaks cost-model container
issue makes pod unhealthy because of error:
```
HorizontalPodAutoscaler v2beta1 is deprecated
```
ref: tektoncd/pipeline#5128
@olegTarassov olegTarassov mentioned this issue May 17, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Tekton Community Roadmap
Status: Done
Milestone
Pipelines v0.41
Development

Successfully merging a pull request may close this issue.

Bump HorizontalPodAutoscaler apiVersion to v2 vdemeester/tektoncd-pipeline
5 participants
@vdemeester @abayer @pritidesai @tekton-robot @Ijmcclung