Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kubecost Container Version health with EKS 1.25+ #1607

Merged
merged 2 commits into from
May 17, 2023

Conversation

olegTarassov
Copy link
Contributor

EKS version 1.25+ breaks cost-model container
issue makes pod unhealthy because of error:

HorizontalPodAutoscaler v2beta1 is deprecated

ref: tektoncd/pipeline#5128

What does this PR do?

Bumps container tag for cost-model that has the new HPA ApiVersion support with EKS version 1.25+. Without it, container is never in healthy state by kubelet.

Motivation

related to this: tektoncd/pipeline#5128

More

  • [X ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

EKS version 1.25+ breaks cost-model container
issue makes pod unhealthy because of error:
```
HorizontalPodAutoscaler v2beta1 is deprecated
```
ref: tektoncd/pipeline#5128
@olegTarassov olegTarassov requested a review from a team as a code owner May 17, 2023 16:28
@olegTarassov olegTarassov temporarily deployed to EKS Blueprints Test May 17, 2023 16:28 — with GitHub Actions Inactive
@olegTarassov olegTarassov changed the title Bump Kubecost Container Version Fix: Kubecost Container Version health with EKS 1.25+ May 17, 2023
@olegTarassov olegTarassov changed the title Fix: Kubecost Container Version health with EKS 1.25+ fix: Kubecost Container Version health with EKS 1.25+ May 17, 2023
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@askulkarni2 askulkarni2 merged commit dde870e into aws-ia:main May 17, 2023
@olegTarassov olegTarassov deleted the fix/kubecost_EKS126 branch May 17, 2023 18:43
gminiba pushed a commit to gminiba/terraform-aws-eks-blueprints that referenced this pull request May 26, 2023
igorbrites pushed a commit to igorbrites/terraform-aws-eks-blueprints that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants