Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local dev work with openshift and kubernetes 1.25 #74

Closed
codificat opened this issue Sep 5, 2022 · 5 comments
Closed

Make local dev work with openshift and kubernetes 1.25 #74

codificat opened this issue Sep 5, 2022 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@codificat
Copy link
Member

Some of the functionality (e.g. manipulating ImageStreams for JupyterHub) requires OpenShift. The current dev instructions in the cnbi spike branch cover kind as a dev platform, which is not enough for this.

Furthermore, I just did a quick test of make kind-start using the latest version of kind (0.15.0, which brings in Kubernetes 1.25) and the outpout suggests there might be some issues with Tekton:

$ make kind-start
enabling experimental podman provider
No kind clusters found.
Creating Cluster
kind create cluster --name "meteor-cnbi" --config hack/kind-config.yaml
enabling experimental podman provider
Creating cluster "meteor-cnbi" ...
 ✓ Ensuring node image (kindest/node:v1.25.0) 🖼 
 ✓ Preparing nodes 📦  
 ✓ Writing configuration 📜 
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌 
 ✓ Installing StorageClass 💾 
Set kubectl context to "kind-meteor-cnbi"
You can now use your cluster with:

kubectl cluster-info --context kind-meteor-cnbi

Have a nice day! 👋
kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.8.0/cert-manager.yaml
namespace/cert-manager created
[snip multiple resources created]
service/tekton-pipelines-webhook created
resource mapping not found for name: "tekton-pipelines" namespace: "" from "https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml": no matches for kind "PodSecurityPolicy" in version "policy/v1beta1"
ensure CRDs are installed first
resource mapping not found for name: "tekton-pipelines-webhook" namespace: "tekton-pipelines" from "https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml": no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1"
ensure CRDs are installed first
make: *** [Makefile:247: kind-start] Error 1
@goern
Copy link
Member

goern commented Sep 5, 2022

looks like the v0.39.0 of tekton-pipelines is using deprecated kubernetes API:

see also tektoncd/pipeline#5128 and tektoncd/pipeline#4112

goern added a commit to goern/meteor-operator that referenced this issue Sep 5, 2022
@goern goern added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 5, 2022
sesheta pushed a commit that referenced this issue Sep 7, 2022
* ✨ add webhooks for defaults and validation
🐛 fix pre-commit fails
:arrow_up minor code cleanup, go warnings removed

Signed-off-by: Christoph Görn <[email protected]>

* ✨ add webhooks validation for required annotations

Signed-off-by: Christoph Görn <[email protected]>

* ⬆️ operator-sdk update to v1.23.0

Signed-off-by: Christoph Görn <[email protected]>

* ✨ refactored the CRD examples for sync with team

Signed-off-by: Christoph Görn <[email protected]>

* 📝 minor cleanup

Signed-off-by: Christoph Görn <[email protected]>

* 📝 update annotation key names

Signed-off-by: Christoph Görn <[email protected]>

* 📝 rename first ReconcilePipelineRun() argument

Signed-off-by: Christoph Görn <[email protected]>

* ✨ implement the current draft CRD, update tests and webhooks

Signed-off-by: Christoph Görn <[email protected]>

* 🐛 add missing files, I deleted them during rebase :/

Signed-off-by: Christoph Görn <[email protected]>

* ✨ added kind to the local bin/

Signed-off-by: Christoph Görn <[email protected]>

* 🐛 renamed the Type to BuildType, due to a bug in go-openapi

Signed-off-by: Christoph Görn <[email protected]>

* 🐛 this is a workaround for #74

Signed-off-by: Christoph Görn <[email protected]>

* ⬆️ update Kubernetes Dashboard

Signed-off-by: Christoph Görn <[email protected]>

* ⬆️ add some feedback...

Signed-off-by: Christoph Görn <[email protected]>

* ⬆️ integrate some more feedback...

Signed-off-by: Christoph Görn <[email protected]>

Signed-off-by: Christoph Görn <[email protected]>
@goern
Copy link
Member

goern commented Sep 14, 2022

/priority important-soon

@sesheta sesheta added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 14, 2022
@codificat codificat moved this to 🆕 New in Planning Board Sep 25, 2022
@codificat
Copy link
Member Author

/wg cnbi

@goern
Copy link
Member

goern commented Oct 1, 2022

I think this is working now, feel free to re-open
/close

@sesheta
Copy link
Member

sesheta commented Oct 1, 2022

@goern: Closing this issue.

In response to this:

I think this is working now, feel free to re-open
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta closed this as completed Oct 1, 2022
Repository owner moved this from 🆕 New to ✅ Done in Planning Board Oct 1, 2022
@sesheta sesheta moved this to ✅ Done in CNBi feature Oct 1, 2022
@codificat codificat moved this from ✅ Done to 👀 In review in Planning Board Oct 5, 2022
@goern goern added this to the v0.2.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: 👀 In review
Status: Done
Development

No branches or pull requests

3 participants