Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename unsigned apk #375

Merged
merged 8 commits into from
Jan 26, 2022
Merged

Rename unsigned apk #375

merged 8 commits into from
Jan 26, 2022

Conversation

Claire1817
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Jan 24, 2022 •
edited
Loading

Unit Test Results

11 files  ±0  11 suites  ±0   8s ⏱️ ±0s
83 tests ±0  83 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 99ef7f2. ± Comparison against base commit be7e1a4.

♻️ This comment has been updated with latest results.

@yostyle
Copy link
Contributor

yostyle commented Jan 24, 2022

LGTM. I let giom to approve this PR

Florian14
Florian14 suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure these are the right variants, we should use the withPinning variant instead of the without one. @giomfo do you confirm?

Florian14
Florian14 suggested changes Jan 25, 2022
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/quality.yml Outdated Show resolved Hide resolved
.github/workflows/sanity_test.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/ui-tests.md Outdated Show resolved Hide resolved
Florian14
Florian14 approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

giomfo
giomfo approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Claire1817 Claire1817 merged commit b353672 into develop Jan 26, 2022
@Claire1817 Claire1817 deleted the cgizard/ISSUE-360-2 branch January 26, 2022 10:27
@Florian14 Florian14 mentioned this pull request Feb 2, 2022
Closed
Florian14 pushed a commit that referenced this pull request Feb 4, 2022
Revert "Rename unsigned apk (#375)"
19491a2 
This reverts commit b353672.
Florian14 pushed a commit that referenced this pull request Feb 4, 2022
Revert "Revert "Rename unsigned apk (#375)""
5c42340 
This reverts commit 19491a2.
Florian14 pushed a commit that referenced this pull request Feb 7, 2022
Revert "Rename unsigned apk (#375)"
915efc8 
This reverts commit b353672.
This was referenced Feb 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Florian14 Florian14 Florian14 approved these changes

@giomfo giomfo giomfo approved these changes

Assignees

@giomfo giomfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Claire1817 @yostyle @giomfo @Florian14