Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the unsigned APKs #360

Closed
giomfo opened this issue Jan 10, 2022 · 3 comments
Closed

Rename the unsigned APKs #360

giomfo opened this issue Jan 10, 2022 · 3 comments
Assignees
Labels

Comments

@giomfo
Copy link
Contributor

giomfo commented Jan 10, 2022

Currently the built unsigned apks have the prefix "vector-" (see). They have to be renamed.

The expected packages are:

  • TchapGplayWithoutvoipWithpinning-release-unsigned(instead of "vector-GplayAgentWithoutvoipWithpinning-release-unsigned")
  • TchapFdroidWithoutvoipWithoutpinning-release-unsigned (instead of "vector-FdroidAgentWithoutvoipWithoutpinning-release-unsigned)
  • BtchapGplayWithoutvoipWithpinning-release-unsigned (instead of "vector-GplayPreprodWithoutvoipWithoutpinning-release-unsigned" - CAUTION I changed here the dimension "pinning" for this package, I think more relevant to be aligned to the prod apk)
  • BtchapFdroidWithoutvoipWithoutpinning-release-unsigned (instead of "vector-FdroidPreprodWithoutvoipWithoutpinning-release-unsigned)

The name of the apks expected in these packages are (in the same order):

  • "gplay-tchap-withoutvoip-withpinning-archi-release-unsigned.apk" (instead of vector-gplay-agent-withoutvoip-withpinning-archi-release-unsigned.apk)
  • "fdroid-tchap-withoutvoip-withoutpinning-archi-release-unsigned.apk" (instead of vector-fdroid-agent-withoutvoip-withoutpinning-archi-release-unsigned.apk)
  • "gplay-btchap-withoutvoip-withpinning-archi-release-unsigned.apk" (instead of vector-gplay-preprod-withoutvoip-withpinning-archi-release-unsigned.apk)
  • "fdroid-btchap-withoutvoip-withoutpinning-archi-release-unsigned.apk" (instead of vector-gplay-preprod-withoutvoip-withoutpinning-archi-release-unsigned.apk)

I would have 2 additional requests

  • can we stop building the "universal" apk by default, or at least stop adding it to the resulting package? I don't see the reason to store it
  • can we replace in the apk name the pattern "release" with the actual tag (without "tchap_" prefix)? For example "v1.99.3" for the tag tchap_v1.99.3
@giomfo giomfo added the android label Jan 10, 2022
@giomfo giomfo changed the title [Github actions] Rename the unsigned APKs Rename the unsigned APKs Jan 10, 2022
@Claire1817
Copy link
Contributor

See build.yml (l38 , 65) => rename apk unsigned

@yostyle
Copy link
Contributor

yostyle commented Jan 11, 2022

  • can we stop building the "universal" apk by default, or at least stop adding it to the resulting package? I don't see the reason to store it

Yes you can do it in vector/build.gradle by updating universalApk true

@yostyle yostyle closed this as completed Jan 12, 2022
@yostyle yostyle reopened this Jan 12, 2022
@yostyle
Copy link
Contributor

yostyle commented Jan 12, 2022

  • can we replace in the apk name the pattern "release" with the actual tag (without "tchap_" prefix)? For example "v1.99.3" for the tag tchap_v1.99.3

By default Gradle uses APK filenames using the following scheme:
modulename-screendensityABI-buildvariant.apk

You can override the outputFilename value on each variant : https://stackoverflow.com/a/59583066
You should use versionName instead of the git tag to get the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants