Fix push notifications and revert variants renaming #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 7, 2022 13:33
Florian14
force-pushed
the
feature/fre/fix_fcm_token_error
branch
from
b2efc3b to
25978d3
Compare
Florian14
changed the title
Claire1817
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#402
Push notifications were broken for some devices since the renaming of the build variants in #375. There is no direct relation between the flavours name and the FCM token since the
applicationIdhas not changed but reverting these changes seems to solve the problem.Also, the
google-services.jsonhas been downloaded again from the google console and updated in the app. It contains now all the application variants (prod/preprod) in a single file which has been moved to the gplay root folder, instead of having one file per variant.We'll see to rename the flavours in the future as this is not a priority change and does not affect the app behaviour.