Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Windows default notification sound should be optional #7210

Closed
qu1ck opened this issue Jun 15, 2023 · 4 comments
Closed

[feat] Windows default notification sound should be optional #7210

qu1ck opened this issue Jun 15, 2023 · 4 comments

Comments

@qu1ck
Copy link

qu1ck commented Jun 15, 2023

Describe the problem

#6680 added default sound when notification is shown. This should be optional.

Describe the solution you'd like

Make the default sound opt-in

Alternatives considered

Make default sound opt-out

Additional context

For my cross-platform app I want to have consistent sound being played on all systems so I play custom sound along with showing the notification.

@killua1zoldyck
Copy link

@FabianLars , can I work on this?

@FabianLars
Copy link
Member

Sure, unfortunately we moved the convo to discord so this issue is missing a bit of context: https://discord.com/channels/616186924390023171/986184168998330371/1118907743269564498

Summary:

@killua1zoldyck
Copy link

killua1zoldyck commented Jun 16, 2023

Oh ok. I will look for smaller and easier to fix issues then since I am new to the stack as well as this project. Thank you!

@amrbashir
Copy link
Member

1.4.1 has been released that removed this default sound, stay tuned for 1.5 where we will add support for specifying the notification sound

amrbashir added a commit that referenced this issue Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants