Skip to content

Commit

Permalink
fix(core): revert #6680, remove default notification sound on Windows
Browse files Browse the repository at this point in the history
ref: #7210
  • Loading branch information
amrbashir committed Jun 17, 2023
1 parent 28921cb commit 5b4d5e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changes/core-revet-windows-notification-default-sound.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'tauri': 'patch'
---

Revert [#6680](https://github.com/tauri-apps/tauri/pull/6680) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms.
3 changes: 0 additions & 3 deletions core/tauri/src/api/notification.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ impl Notification {
{
notification.app_id(&self.identifier);
}

// will be parsed as a `::winrt_notification::Sound`
notification.sound_name("Default");
}
#[cfg(target_os = "macos")]
{
Expand Down

0 comments on commit 5b4d5e7

Please sign in to comment.