Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add notification sound #7269

Merged
merged 15 commits into from
Aug 8, 2023
Merged

feat: add notification sound #7269

merged 15 commits into from
Aug 8, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 20, 2023 •
edited
Loading

ref: #7210

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner June 20, 2023 13:56
@amrbashir amrbashir force-pushed the feat/notification-sound branch from 14352a8 to 3b59795 Compare June 20, 2023 14:00
lucasfernog
lucasfernog requested changes Jun 20, 2023
View reviewed changes
core/tauri/src/api/notification.rs Outdated Show resolved Hide resolved
tooling/api/src/notification.ts Outdated Show resolved Hide resolved
@lucasfernog
Copy link
Member

@amrbashir I've pushed a change to read NSUserNotificationDefaultSoundName but https://github.com/h4llow3En/mac-notification-sys/blob/7ab3864527698472224671093e581d4d1880851f/src/notification.rs#LL339C54-L339C54 doesn't really let us play it (or any custom sound defined in the app bundle).

@amrbashir
Copy link
Member Author

Yeah, looks like we need to open a PR upstream

@amrbashir amrbashir mentioned this pull request Jul 3, 2023
Merged
@lucasfernog lucasfernog merged commit 6c408b7 into 1.x Aug 8, 2023
@lucasfernog lucasfernog deleted the feat/notification-sound branch August 8, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog