Changed PositionToEnd refferences to Angle #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see how it's required if it gets offset. The only consequence I can see happening from this commit is that all notes will move to a slightly different point on the circle.
I don't see how it's required if it gets offset. The only consequence I can see happening from this commit is that all notes will move to a slightly different point on the circle.
naoei
reviewed
Apr 6, 2020
|
Testing this, and the cursor and the paddle both seems completely backwards, they do not follow to each others movements correctly. |
|
The issue was that the whole playfield was flipped. I didn't noticed about that thing.. buut.... |
|
hm... we might have to unflip the Y axis for the cursor then |
|
You should probably just have it flipped in GetHitObjectAngle |
naoei
requested changes
Apr 7, 2020
naoei
approved these changes
Apr 7, 2020
This was referenced Apr 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important pr that ensures that all objects call from the Angle prop and not the PositionToEnd.
This should fix issues with minute errors of angles from objects.