Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premature calculations of scores/display of score screen before the map has finished. #48

Closed
Coppertine opened this issue Apr 3, 2020 · 9 comments · Fixed by #56
Closed
Labels
bug Something isn't working

Comments

@Coppertine
Copy link
Contributor

Coppertine commented Apr 3, 2020

This has happened on every Tau map that I play,
Basically, just a couple seconds before the map is finished, there is a little lagspike followed with beats being unclickable that then puts you to the results screen. (Similar to the end of This beatmap in stable)

@naoei naoei added the bug Something isn't working label Apr 3, 2020
@LumpBloom7
Copy link
Collaborator

I can't really recreate this. Perhaps you have some footage instead? or some exact reproduction steps?

@Coppertine
Copy link
Contributor Author

Coppertine commented Apr 3, 2020

Here is a recording of a map known to have slider art at the end (at 4:22, you can not hit the last two objects in the map).
https://drive.google.com/open?id=1ebBK7cvseIdfD9F_U6JFX6ACbVrOkemx

@Coppertine
Copy link
Contributor Author

I think it happens when the last objects have spinners or sliders on them.

@naoei
Copy link
Member

naoei commented Apr 3, 2020

Could be the case, needs further investigation.

@Coppertine
Copy link
Contributor Author

Will test out maps which uses spinners or slider art at the end..

@frenzibyte
Copy link
Contributor

frenzibyte commented Apr 5, 2020

This sounds like a DrawableTauHitObject incorrectly applying judgement results somewhere, the map will be considered completed by the JudgementProcessor when all hit objects and their nested objects are judged.

@naoei
Copy link
Member

naoei commented Apr 7, 2020

Fixed via #53 & #51

@naoei naoei closed this as completed Apr 7, 2020
@Coppertine
Copy link
Contributor Author

Request for Reopen, none of my PR's affected the JudgementProcessor

@naoei naoei reopened this Apr 8, 2020
@smoogipoo
Copy link

The issue here may be related to the double application of the result in Miss cases, as @iiSalman mentioned:

https://github.com/Altenhh/tau/blob/8436fa850bad29e94d1ab055581799e2ac25bdb0/osu.Game.Rulesets.tau/Objects/Drawables/DrawabletauHitObject.cs#L105-L111

DHO should probably throw an exception if that's ever done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants