Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract TauHitObject #7

Closed
naoei opened this issue Nov 28, 2019 · 3 comments · Fixed by #107
Closed

Abstract TauHitObject #7

naoei opened this issue Nov 28, 2019 · 3 comments · Fixed by #107
Labels
code quality

Comments

@naoei
Copy link
Member

naoei commented Nov 28, 2019

base code should be split to avoid copy-pasting code
@naoei naoei modified the milestones: 1.0.5, 1.0.6 Mar 9, 2020
@naoei naoei removed this from the 1.0.6 milestone Mar 19, 2020
@Coppertine
Copy link
Contributor

Fixed at #51

@Coppertine
Copy link
Contributor

The code you wrote was already abstracted, will be used in #43 and #50

@LumpBloom7
Copy link
Collaborator

I'll deal with this rn.

@LumpBloom7 LumpBloom7 mentioned this issue Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make TauHitObject abstract LumpBloom7/tau
3 participants
@LumpBloom7 @naoei @Coppertine