Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Convergence Plots by default #1823

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Oct 30, 2021

Disable progress bars and convergence plots by default. The log level is changed in #1843.

Description

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

tardis/base.py Outdated Show resolved Hide resolved
@atharva-2001 atharva-2001 changed the title Add tardis_gui option Disable Progress Bars and Convergence Plots by default Jan 7, 2022
@atharva-2001 atharva-2001 marked this pull request as ready for review January 7, 2022 12:43
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1823 (69e5b50) into master (33772e9) will increase coverage by 1.27%.
The diff coverage is n/a.

❗ Current head 69e5b50 differs from pull request most recent head bb06045. Consider uploading reports for the commit bb06045 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
+ Coverage   58.22%   59.50%   +1.27%     
==========================================
  Files          66       69       +3     
  Lines        6722     7707     +985     
==========================================
+ Hits         3914     4586     +672     
- Misses       2808     3121     +313     
Impacted Files Coverage Δ
tardis/tardis/io/logger/logger.py 72.13% <0.00%> (-21.62%) ⬇️
.../tardis/montecarlo/montecarlo_numba/interaction.py 19.04% <0.00%> (-10.69%) ⬇️
...dis/montecarlo/montecarlo_numba/numba_interface.py 36.53% <0.00%> (-9.62%) ⬇️
...s/tardis/montecarlo/montecarlo_numba/estimators.py 34.48% <0.00%> (-9.27%) ⬇️
tardis/tardis/plasma/properties/atomic.py 53.12% <0.00%> (-8.64%) ⬇️
...rdis/plasma/properties/transition_probabilities.py 24.03% <0.00%> (-7.55%) ⬇️
tardis/tardis/plasma/base.py 48.63% <0.00%> (-7.27%) ⬇️
...is/tardis/plasma/properties/continuum_processes.py 35.51% <0.00%> (-1.49%) ⬇️
...s/tardis/visualization/widgets/custom_abundance.py 14.03% <0.00%> (-0.40%) ⬇️
tardis/tardis/analysis.py 30.16% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33772e9...bb06045. Read the comment docs.

tardis/base.py Outdated Show resolved Hide resolved
tardis/base.py Outdated Show resolved Hide resolved
@jaladh-singhal jaladh-singhal changed the title Disable Progress Bars and Convergence Plots by default Disable Convergence Plots by default Feb 28, 2022
@jaladh-singhal jaladh-singhal merged commit 7ccabdc into tardis-sn:master Feb 28, 2022
andrewfullard pushed a commit that referenced this pull request Mar 3, 2022
* Include the show_convergence_plots option in the run_tardis function in convergence plots notebook

* Remove unwanted changes

* [build docs]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants