Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build failure due to PR #1823 #1918

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Mar 1, 2022

This PR changes the convergence plots notebook corresponding to the changes done in PR #1823.

Description

Motivation and context

The documentation build pipeline is failing.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Link to the documentation: https://atharva-2001.github.io/tardis/branch/fix_docs_cplots/io/visualization/convergence_plot.html

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1918 (6dc0c71) into master (7ccabdc) will not change coverage.
The diff coverage is n/a.

❗ Current head 6dc0c71 differs from pull request most recent head 0c546b8. Consider uploading reports for the commit 0c546b8 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1918   +/-   ##
=======================================
  Coverage   59.04%   59.04%           
=======================================
  Files          70       70           
  Lines        7767     7767           
=======================================
  Hits         4586     4586           
  Misses       3181     3181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ccabdc...0c546b8. Read the comment docs.

@andrewfullard andrewfullard merged commit dadc137 into tardis-sn:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants