Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching progress bars page to rst #1848

Merged
merged 6 commits into from
Jan 10, 2022

Conversation

isaacgsmith
Copy link
Member

Description

Switches progress bars page of documentation from a notebook to RST.

Motivation and context

We didn't need TARDIS to run on that page.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

https://smithis7.github.io/tardis/branch/progress_bars_doc/io/output/progress_bars.html

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #1848 (2f500c8) into master (f24be9a) will not change coverage.
The diff coverage is n/a.

❗ Current head 2f500c8 differs from pull request most recent head 10081a7. Consider uploading reports for the commit 10081a7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1848   +/-   ##
=======================================
  Coverage   57.65%   57.65%           
=======================================
  Files          66       66           
  Lines        6809     6809           
=======================================
  Hits         3926     3926           
  Misses       2883     2883           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24be9a...10081a7. Read the comment docs.

@wkerzendorf wkerzendorf merged commit 69fac16 into tardis-sn:master Jan 10, 2022
@isaacgsmith isaacgsmith deleted the progress_bars_doc branch January 25, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants