Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove with_entries() and keep_raw from Matrix #3539

Merged
merged 5 commits into from
Nov 18, 2021

Conversation

strongoier
Copy link
Contributor

Related issue = #2880

This is a follow-up PR of #3536. Meanwhile, it fixes #2718 by the way.

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: c3ae545

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6195e6c48985d80009f4767b

@strongoier
Copy link
Contributor Author

/format

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

python/taichi/lang/matrix.py Outdated Show resolved Hide resolved
@strongoier
Copy link
Contributor Author

/format

@strongoier strongoier merged commit c3f5044 into taichi-dev:master Nov 18, 2021
@strongoier strongoier deleted the remove-with-entries branch November 18, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] Clean up keep_raw
3 participants