Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ti.Matrix #2880

Closed
strongoier opened this issue Sep 6, 2021 · 1 comment
Closed

Simplify ti.Matrix #2880

strongoier opened this issue Sep 6, 2021 · 1 comment

Comments

@strongoier
Copy link
Contributor

strongoier commented Sep 6, 2021

Currently ti.Matrix has become a single class with more than 1000 lines, with all deprecated/obsolete/unused/rarely used features mixed together. For better code maintainability, we need to carefully decide what should be exposed to users and clean up this class.

@strongoier strongoier mentioned this issue Sep 6, 2021
43 tasks
@strongoier strongoier changed the title Simplify ti.Matrix and ti.Vector Simplify ti.Matrix Sep 16, 2021
@strongoier strongoier reopened this Sep 16, 2021
@victoriacity
Copy link
Member

victoriacity commented Sep 21, 2021

I'd recommend moving the linear algebra methods (inverse(), diag(), determinant()) to linalg.py so that we have a clear distinction between API and math implementations. For example, matrix.inverse() will become an alias of ti.inverse(matrix), similar to NumPy ndarrays and PyTorch tensors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants