Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Remove variable() of Matrix/Struct and empty() of Matrix/StructType #3531

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

strongoier
Copy link
Contributor

Related issue = #2880

There are lots of dependencies of the ti.Matrix.empty internal method (#3524). This PR serves as the first step towards cleaning them up.

@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: e6594bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61949fd4c9e404000735c04d

@strongoier
Copy link
Contributor Author

/format

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 27700ea into taichi-dev:master Nov 17, 2021
@strongoier strongoier deleted the remove-internal-api branch November 17, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants