Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Enable local tensors as writeback binary operation results #3517

Merged

Conversation

strongoier
Copy link
Contributor

Related issue = #2590, #2880, #2637

This PR rewrites element_wise_writeback_binary to enable local tensor results. To make it work, Matrix.__init__ is refactored a little bit to clean the logic and cover missing cases.

@netlify
Copy link

netlify bot commented Nov 15, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 5e29019

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61921155bbba740007f44ee5

@strongoier
Copy link
Contributor Author

/format

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants