-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR] Support local tensor #2637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hin offloaded pass
k-ye
reviewed
Aug 5, 2021
strongoier
reviewed
Aug 5, 2021
Co-authored-by: Ye Kuang <[email protected]>
/format |
/format |
/format |
/format |
/format |
Merged
This was referenced Oct 18, 2021
This was referenced Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #2590
IR
Python:
Initial IR:
Lower AST (eliminate IdExpression):
Offloaded:
AllocaStmt may be converted into GlobalTemporaryStmt or just keep AllocaStmt
Issues
Currently, there are three issues:
Offload pass only deal with ConstStmt type for offset in PtrOffsetStmt. This will introduce some code restrictions but should be easy to resolve.. Done with another PR.2. for I in ti.grouped(ti.ndrange()): need to make sure Alloca TensorType inside loop body.
3. Loop indices are looked up by Alloca id in some places. Extra work is needed to extract different dim indices from the same Alloca TensorType