Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Make dynamic indexing compatible with grouped loop indices of ndrange fors #3228

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

strongoier
Copy link
Contributor

Related issue = #2590, #2637

Yet another remaining issue in #2637. Grouped loop indices of ndrange fors are exposed to users as ti.Vector and are set via assignments to individual loop variables. Dynamic indexing can naturally work here, and we just need to move the ti.Vector definition inside the loop to avoid unnecessary usage of the global temporary buffer.

@netlify
Copy link

netlify bot commented Oct 19, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc ready!

🔨 Explore the source changes: 71fe76a

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/616e977474719e0007ed4b62

😎 Browse the preview: https://deploy-preview-3228--jovial-fermat-aa59dc.netlify.app

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants