Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Clean up keep_raw #2718

Closed
squarefk opened this issue Aug 17, 2021 · 0 comments · Fixed by #3539
Closed

[refactor] Clean up keep_raw #2718

squarefk opened this issue Aug 17, 2021 · 0 comments · Fixed by #3539
Labels
good first issue A great chance for starters refactor Refactor of API or codebases welcome contribution

Comments

@squarefk
Copy link
Contributor

Few places use keep_raw from the python Matrix class constructor. Currently, the parameter list is too long. It should be great to remove keep_raw option and find an alternative way to do so.

def __iter__(self):
for ind in self.r:
yield ti.Vector(list(ind), keep_raw=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A great chance for starters refactor Refactor of API or codebases welcome contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant