[bug] recursively include examples in distribution script #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [vulkan] Add Vulkan API * fix * support osx * [skip ci] enforce code format Co-authored-by: Taichi Gardener <[email protected]>
* [vulkan] Add per kernel info structs * trace
This reverts commit f5f5ab2.
|
|
victoriacity
changed the title
Closed
|
Ailing, If this one-liner change looks good then we can merge it to fix #2588. Thanks! |
ailzhang
approved these changes
Jul 27, 2021
|
Btw since now we are testing in install mode, we should be able to test another example other than minimal so that similar bug can be caught in the future. I'm okay with adding the test in this PR or a followup :D |
Sounds good! I would be inclined to directly adding the test into this PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #2588
Note: this will still not include CHI examples in PyPI distribution.