Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taichi example missing #2588

Closed
gwoweiming opened this issue Jul 26, 2021 · 2 comments · Fixed by #2591
Closed

taichi example missing #2588

gwoweiming opened this issue Jul 26, 2021 · 2 comments · Fixed by #2591
Assignees
Labels
potential bug Something that looks like a bug but not yet confirmed

Comments

@gwoweiming
Copy link

[Taichi] version 0.7.26, llvm 10.0.0, commit e37bdb5, win, python 3.9.6

taichi examples only have {minimal}

@gwoweiming gwoweiming added the potential bug Something that looks like a bug but not yet confirmed label Jul 26, 2021
@gwoweiming gwoweiming changed the title taichi example taichi example missing Jul 26, 2021
@k-ye
Copy link
Member

k-ye commented Jul 27, 2021

Oops, this is because of #2475. For now you can directly execute these examples w/ python3 $EXAMPLE_NAME. @victoriacity could you help take a look around

@register
def example(self, arguments: list = sys.argv[2:]):
?

@victoriacity
Copy link
Member

victoriacity commented Jul 27, 2021

It looks like the example subfolders are missing in the PyPI distribution, while in the GitHub release the examples are present.

I guess it would be related to the ti dist scripts and I'm looking into this.

For the specific case of 0.7.26, the examples are manually included as packages in the python/setup.py script. Setuptools does not seem to recursively look for subfolders so all example subfolders have been missed in the PyPI distribution. The fix to 0.7.26 is presented here.

After #2540 the MANIFEST.in file instead need to be changed to recursively include examples/ folder, see #2591.

I guess the lesson learned is to be careful with directory structure changes and double check related paths in CI and distribution workflows.

victoriacity added a commit to victoriacity/taichi that referenced this issue Jul 27, 2021
victoriacity added a commit to victoriacity/taichi that referenced this issue Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential bug Something that looks like a bug but not yet confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants