Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Add Vulkan API #2299

Merged
merged 4 commits into from
Apr 26, 2021
Merged

[vulkan] Add Vulkan API #2299

merged 4 commits into from
Apr 26, 2021

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Apr 26, 2021

Related issue = #2298

@g1n0st could you help take a look, thanks :-)

[Click here for the format server]


@k-ye k-ye requested a review from g1n0st April 26, 2021 07:45
@k-ye k-ye changed the base branch from master to vulkan April 26, 2021 07:48
Comment on lines 26 to 29
if (TI_WITH_VULKAN)
set(TI_WITH_VULKAN OFF)
message(WARNING "Vulkan backend not supported on OS X. Setting TI_WITH_VULKAN to OFF.")
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not support Vulkan backend on OS X?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@k-ye k-ye merged commit eb6162b into taichi-dev:vulkan Apr 26, 2021
@k-ye k-ye deleted the vk1 branch April 26, 2021 09:11
k-ye added a commit to k-ye/taichi that referenced this pull request Apr 30, 2021
* [vulkan] Add Vulkan API

* fix

* support osx

* [skip ci] enforce code format

Co-authored-by: Taichi Gardener <[email protected]>
k-ye added a commit that referenced this pull request May 6, 2021
* [vulkan] Add Vulkan API

* fix

* support osx

* [skip ci] enforce code format

Co-authored-by: Taichi Gardener <[email protected]>
k-ye added a commit that referenced this pull request May 28, 2021
* [vulkan] Add Vulkan API

* fix

* support osx

* [skip ci] enforce code format

Co-authored-by: Taichi Gardener <[email protected]>
k-ye added a commit that referenced this pull request May 28, 2021
* [vulkan] Add Vulkan API

* fix

* support osx

* [skip ci] enforce code format

Co-authored-by: Taichi Gardener <[email protected]>
@k-ye k-ye mentioned this pull request May 29, 2021
k-ye added a commit that referenced this pull request Jul 27, 2021
* [vulkan] Add Vulkan API (#2299)

* [vulkan] Add Vulkan API

* fix

* support osx

* [skip ci] enforce code format

Co-authored-by: Taichi Gardener <[email protected]>

* [vulkan] Add per kernel info structs (#2300)

* [vulkan] Add per kernel info structs

* trace

* abort python2 import

* abort python2 import

* [bug] recursively include examples in distribution script

* Revert "abort python2 import"

This reverts commit f5f5ab2.

* revert abort python 2 import for PR branches

Co-authored-by: Ye Kuang <[email protected]>
Co-authored-by: Taichi Gardener <[email protected]>
strongoier pushed a commit that referenced this pull request Aug 30, 2021
* [vulkan] Add Vulkan API (#2299)

* [vulkan] Add Vulkan API

* fix

* support osx

* [skip ci] enforce code format

Co-authored-by: Taichi Gardener <[email protected]>

* [vulkan] Add per kernel info structs (#2300)

* [vulkan] Add per kernel info structs

* trace

* abort python2 import

* abort python2 import

* [skip ci] add initial custom struct test

* [skip ci] add struct class

* add custom struct tests

* Auto Format

* add StructField and CompoundType

* [skip ci] add custom types; struct assignment and elementwise ops

* expose integer and float primitive types

* fix character for formatter

* make custom struct tests pass

* add custom struct tests

* Auto Format

* add struct and compound type documentation

* Auto Format

* make Matrix.to_numpy() work for both global field and local matrix

* fix /lang/__init__.py

* use enum Layout

* Auto Format

* use np.int32 for test_from_numpy_struct

* fix doc typo

* use ti.test()

* address code review, make struct broadcast and empty copy recursive

* add struct type initializer and type cast tests

* Auto Format

* change assertion to raising errors

* Auto Format

Co-authored-by: Ye Kuang <[email protected]>
Co-authored-by: Taichi Gardener <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants