[lang] "ti.chain_compare" now can return python-scope constants #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d1a356e.
xumingkuan
reviewed
Jun 29, 2020
xumingkuan
approved these changes
Jun 30, 2020
|
What if the user calls a |
Do we have a test on this? If not, let me write one. |
This comment has been minimized.
This comment has been minimized.
We don't have one now. Please write one, likely near |
archibate
commented
Jul 3, 2020
| b = ti.var(ti.i32, ()) | ||
|
|
||
| @ti.func | ||
| def why_this_foo_fail(n): |
|
|
||
| @ti.kernel | ||
| def func(): | ||
| a[None] = 0 <= foo(2) < 1 |
There was a problem hiding this comment.
Done here @yuanming-hu.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d1a356e.
Related issue = to make a way for #1344
[Click here for the format server]