[Lang] Add ti.static_assert for compile-time assertations #1344

archibate · 2020-06-27T13:30:56Z

Related issue = #

TODO: add check_out_of_bound doc too.

codecov · 2020-06-27T14:35:18Z

Codecov Report

❗ No coverage uploaded for pull request base (master@28e005c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1344   +/-   ##
=========================================
  Coverage          ?   66.76%           
=========================================
  Files             ?       37           
  Lines             ?     5197           
  Branches          ?      933           
=========================================
  Hits              ?     3470           
  Misses            ?     1566           
  Partials          ?      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e005c...bd2e4a3. Read the comment docs.

docs/debugging.rst

isdanni

Great work! 🚀 🎸

docs/debugging.rst

Rullec · 2020-06-28T01:39:30Z

docs/debugging.rst

+    def is_odd(x: ti.template()):
+        ti.static_assert(x.data_type() == ti.i32, "is_odd() is only supported for i32")
+        return x % 2 == 1
+


We may give ti.static_assert a function demonstration here? so that people can realize it receive 2 parameters, the first one is assert expresstion and the second is a statement.

I thought all Python users who know assert knows this failure message feature?

docs/debugging.rst

Rullec · 2020-06-28T01:45:45Z

Good morning @archibate !

Thanks for your hard work! It's a very nice doc that explains the usage of debugging tools clearly. only + few nits.

docs/debugging.rst

Co-authored-by: Danni <[email protected]> Co-authored-by: Xudong Feng <[email protected]>

docs/debugging.rst

Co-authored-by: Yuanming Hu <[email protected]> Co-authored-by: Xudong Feng <[email protected]> Co-authored-by: Danni <[email protected]>

docs/debugging.rst

isdanni

Nothing much for me to add here! 🚀

Co-authored-by: Danni <[email protected]> Co-authored-by: Yuanming Hu <[email protected]>

…nto static-assert

docs/debugging.rst

Co-authored-by: Danni <[email protected]>

yuanming-hu

Thank you! LGTM except for a few more wording nits.

docs/debugging.rst

Co-authored-by: Yuanming Hu <[email protected]>

archibate · 2020-07-04T03:39:32Z

Great! I'll merge once CI pass, hope our doc&tools could help users to debug their program easier!

yuanming-hu

Thanks. I think this PR is ready to merge anytime.

tests/python/test_assert.py

archibate added 2 commits June 27, 2020 21:27

[Lang] Add ti.static_assert for compile-time assertations

685fe0c

add index

809a7d2

archibate requested review from yuanming-hu, k-ye, isdanni and taichi-gardener June 27, 2020 13:30

well doc merge

6590d0f

archibate requested a review from Rullec June 27, 2020 14:09

isdanni reviewed Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jun 28, 2020

View reviewed changes

Rullec reviewed Jun 28, 2020

View reviewed changes

Rullec mentioned this pull request Jun 28, 2020

[doc] Add user utilities doc #1295

Merged

archibate commented Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

archibate commented Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

archibate commented Jun 28, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

archibate and others added 2 commits June 28, 2020 10:16

[skip ci] Apply suggestions from code review

38b6e26

Co-authored-by: Danni <[email protected]> Co-authored-by: Xudong Feng <[email protected]>

[skip ci] enforce code format

30496dd

yuanming-hu reviewed Jun 28, 2020

View reviewed changes

[skip ci] Apply suggestions from code review

1a5c832

Co-authored-by: Yuanming Hu <[email protected]> Co-authored-by: Xudong Feng <[email protected]> Co-authored-by: Danni <[email protected]>

archibate requested review from Rullec, isdanni and yuanming-hu June 28, 2020 22:42

isdanni reviewed Jul 1, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jul 1, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jul 1, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jul 1, 2020

View reviewed changes

archibate added the waiting for reply label Jul 2, 2020

archibate and others added 3 commits July 2, 2020 13:02

Apply suggestions from code review

a26670b

Co-authored-by: Danni <[email protected]> Co-authored-by: Yuanming Hu <[email protected]>

Merge branch 'master' into static-assert

7129673

Merge branch 'master' into static-assert

d882bc4

archibate added python Python engineering related large changeset The PR contains a large changeset and reviewing may take times labels Jul 2, 2020

archibate added 4 commits July 3, 2020 16:18

Merge branch 'static-assert' of https://github.com/archibate/taichi i…

76d33e3

…nto static-assert

Merge branch 'master' into static-assert

4ead322

Merge branch 'master' into static-assert

d819cf0

well @ti.pyfunc

bcc594a

archibate requested a review from isdanni July 3, 2020 16:59

isdanni reviewed Jul 4, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jul 4, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni reviewed Jul 4, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

isdanni approved these changes Jul 4, 2020

View reviewed changes

Apply suggestions from code review

7991cea

Co-authored-by: Danni <[email protected]>

yuanming-hu approved these changes Jul 4, 2020

View reviewed changes

docs/debugging.rst Outdated Show resolved Hide resolved

docs/debugging.rst Outdated Show resolved Hide resolved

docs/debugging.rst Outdated Show resolved Hide resolved

docs/debugging.rst Outdated Show resolved Hide resolved

docs/debugging.rst Outdated Show resolved Hide resolved

[skip ci] Apply suggestions from code review

df7027c

Co-authored-by: Yuanming Hu <[email protected]>

archibate requested a review from yuanming-hu July 4, 2020 03:38

archibate added doc Documentation related issues & PRs and removed large changeset The PR contains a large changeset and reviewing may take times labels Jul 4, 2020

yuanming-hu approved these changes Jul 4, 2020

View reviewed changes

tests/python/test_assert.py Outdated Show resolved Hide resolved

Update tests/python/test_assert.py

bd2e4a3

archibate merged commit eb40824 into taichi-dev:master Jul 5, 2020

FantasyVR mentioned this pull request Jul 8, 2020

[release] v0.6.17 #1436

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lang] Add ti.static_assert for compile-time assertations #1344

[Lang] Add ti.static_assert for compile-time assertations #1344

archibate commented Jun 27, 2020 •

edited

Loading

codecov bot commented Jun 27, 2020 •

edited

Loading

isdanni left a comment

Rullec Jun 28, 2020

archibate Jul 3, 2020

Rullec commented Jun 28, 2020

isdanni left a comment

yuanming-hu left a comment

archibate commented Jul 4, 2020

yuanming-hu left a comment

[Lang] Add ti.static_assert for compile-time assertations #1344

[Lang] Add ti.static_assert for compile-time assertations #1344

Conversation

archibate commented Jun 27, 2020 • edited Loading

codecov bot commented Jun 27, 2020 • edited Loading

Codecov Report

isdanni left a comment

Choose a reason for hiding this comment

Rullec Jun 28, 2020

Choose a reason for hiding this comment

archibate Jul 3, 2020

Choose a reason for hiding this comment

Rullec commented Jun 28, 2020

isdanni left a comment

Choose a reason for hiding this comment

yuanming-hu left a comment

Choose a reason for hiding this comment

archibate commented Jul 4, 2020

yuanming-hu left a comment

Choose a reason for hiding this comment

archibate commented Jun 27, 2020 •

edited

Loading

codecov bot commented Jun 27, 2020 •

edited

Loading