[llvm] Further improve LLVM 10 compatibility by using RTLD_DEEPBIND #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
changed the title
yuanming-hu
reviewed
Jun 30, 2020
There was a problem hiding this comment.
Thanks for fixing this - I'm not sure if this will break Taichi on other Linux/OS X environment, since how RTLD_DEEPBIND works is unclear to me.
At least we should only do this for Linux? Here RTLD_DEEPBIND is used for both Linux and Mac.
Also note that LLVM 10 is statically linked into libtaichi.so - there's no libLLVM-10.so.
|
Well, but the stack trace tells me: See? The stupid |
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
=======================================
Coverage 85.58% 85.58%
=======================================
Files 19 19
Lines 3371 3371
Branches 624 624
=======================================
Hits 2885 2885
Misses 356 356
Partials 130 130 Continue to review full report at Codecov.
|
Actually this might be the reason of this failure. I found rust-lang/rust#18671 (comment) and https://xamarin.github.io/bugzilla-archives/57/57742/bug.html. Both reported that statically linked LLVM has caused this problem. |
yuanming-hu
approved these changes
Jul 2, 2020
Co-authored-by: Yuanming Hu <[email protected]>
xumingkuan
reviewed
Jul 2, 2020
| TI_ASSERT(var.snode()->num_active_indices == 0); | ||
| TI_ASSERT_INFO( | ||
| var.snode()->num_active_indices == 0, | ||
| "Please always use 'x[None]' (instead of simply 'x') to access any 0-D tensor." |
There was a problem hiding this comment.
Suggested change
| "Please always use 'x[None]' (instead of simply 'x') to access any 0-D tensor." | |
| "Please always use 'x[None]' (instead of simply 'x') to access any 0-D tensor."); |
There was a problem hiding this comment.
Sorry for merging without proofread! Did a OFT fix in #1356.
archibate
added a commit
to archibate/taichi
that referenced
this pull request
Jul 2, 2020
archibate
added a commit
that referenced
this pull request
Jul 3, 2020
* Revert "[skip ci] revert ti.chain_compare" This reverts commit d1a356e. * add func eval twice test according to @yuanming-hu * fix #1355 (comment) * [skip ci] enforce code format Co-authored-by: Taichi Gardener <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1326
[Click here for the format server]
Failed to start OpenGL on a very old NVIDIA card which doesn't support compute shader, RTLD_DEEPBIND seems fix that issue.