Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱Add check to disallow hcloud servers without ssh key #1413

Merged
merged 3 commits into from
Aug 10, 2024
Merged

🌱Add check to disallow hcloud servers without ssh key #1413

merged 3 commits into from
Aug 10, 2024

Conversation

yrs147
Copy link
Contributor

@yrs147 yrs147 commented Aug 1, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1402

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

janiskemper
janiskemper requested changes Aug 1, 2024
View reviewed changes
pkg/services/hcloud/server/server.go Outdated Show resolved Hide resolved
pkg/services/hcloud/server/server.go Outdated Show resolved Hide resolved
pkg/services/hcloud/server/server.go Outdated Show resolved Hide resolved
janiskemper
janiskemper reviewed Aug 2, 2024
View reviewed changes
Copy link
Contributor

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot the unit tests. I believe that we can test this. There should be existing tests probably for related cases. Can you check? Should be about that we set the condition when needed

@batistein batistein marked this pull request as ready for review August 10, 2024 14:10
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Aug 10, 2024
@batistein batistein merged commit 9a170a2 into main Aug 10, 2024
14 checks passed
@batistein batistein deleted the yrs/hcloud-server-ssh branch August 10, 2024 16:24
@janiskemper janiskemper mentioned this pull request Aug 12, 2024
Closed
@echozio echozio mentioned this pull request Aug 25, 2024
Closed
guettli added a commit that referenced this pull request Aug 29, 2024
@guettli
Revert "🌱Add check to disallow hcloud servers without ssh key (#1413)"
7d91af3 
This reverts commit 9a170a2.

We revert this, because some users want to provision clusters without ssh key.
guettli added a commit that referenced this pull request Aug 29, 2024
@guettli
Revert "🌱Add check to disallow hcloud servers without ssh key (#1413)" (
72736bf 
#1465)

* Revert "🌱Add check to disallow hcloud servers without ssh key (#1413)"

This reverts commit 9a170a2.

We revert this, because some users want to provision clusters without ssh key.

* ... removed test, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiskemper janiskemper janiskemper approved these changes

Assignees
No one assigned
Labels
area/code Changes made in the code directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow HCloud servers without SSH key
3 participants
@yrs147 @janiskemper @batistein