Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Add check to disallow hcloud servers without ssh key #1413

Merged
merged 3 commits into from
Aug 10, 2024
Merged

🌱Add check to disallow hcloud servers without ssh key #1413

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1116c8
🌱Add check to disallow hcloud servers without ssh key
yrs147 Aug 1, 2024
f4280ff
🌱Minor change
yrs147 Aug 1, 2024
53da8f6
🌱Minor change
yrs147 Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/services/hcloud/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,17 @@ func (s *Service) createServer(ctx context.Context) (*hcloud.Server, error) {
}
}

if len(sshKeySpecs) == 0 {
conditions.MarkFalse(
s.scope.HCloudMachine,
infrav1.ServerCreateSucceededCondition,
infrav1.SSHKeyNotFoundReason,
clusterv1.ConditionSeverityError,
"No SSH key configured for the server. Please add an SSH key",
)
return nil, errServerCreateNotPossible
}

// get all ssh keys that are stored in HCloud API
sshKeysAPI, err := s.scope.HCloudClient.ListSSHKeys(ctx, hcloud.SSHKeyListOpts{})
if err != nil {
Expand Down
Loading