Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow HCloud servers without SSH key #1402

Closed
janiskemper opened this issue Jul 29, 2024 · 0 comments · Fixed by #1413
Closed

Disallow HCloud servers without SSH key #1402

janiskemper opened this issue Jul 29, 2024 · 0 comments · Fixed by #1413
Assignees

Comments

@janiskemper
Copy link
Contributor

/kind feature

Describe the solution you'd like
No SSH key should be usually (otherwise please comment) a configuration issue. We can easily catch that and make users aware of this.

This will introduce a breaking change and will affect everyone provisioning HCloud servers without ssh key.

However, I think the drawbacks are not as severe and the advantage will be that no-one can misconfigure it.

We will add a condition to HCloudMachine that there is no ssh key.

The ssh key can be provided by the feature of adding it to the Hetzner secret even on the fly, without changing any templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants