Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: LN manual channel with external node #1972

Closed
pwltr opened this issue Jun 8, 2024 · 3 comments · Fixed by #2246
Closed

[Feature]: LN manual channel with external node #1972

pwltr opened this issue Jun 8, 2024 · 3 comments · Fixed by #2246
Assignees
Labels
enhancement New feature or request feature request A user has an idea for the app

Comments

@pwltr
Copy link
Collaborator

pwltr commented Jun 8, 2024

Describe the problem

Blocked by synonymdev/react-native-ldk#30

While Bitkit does support LNURL-channel, there is no way to connect to nodes that do not generate such a QR.

Describe the solution

Add the flow for adding non Blocktank nodes. Also need to make sure open/close transactions are marked as such in the activity.

image

@pwltr pwltr added enhancement New feature or request feature request A user has an idea for the app labels Jun 8, 2024
@pwltr pwltr self-assigned this Jun 8, 2024
@JeanlChristophe
Copy link

jay will do synonymdev/react-native-ldk#30. it will be available for August. only one day of work.

@JeanlChristophe
Copy link

@catch-21
Copy link
Contributor

catch-21 commented Sep 26, 2024

Tested on 1.0.5 (136)

We should allow those in US/Canada to use this feature: #2252

Crash on iPhone if 'Continue' is pressed without entering any node details in on Manual Setup screen. This then may have broken my LDK node, or coincidentally this occurred. #2253

Error shown without message on android in same scenario as above (2). Not raised a new issue but added observation here #2253 (comment). A fix must be tested on both platforms.

Host and Port are not required to proceed to attempt swipe and transfer, only the Node ID is. Form validation could be improved here for mandatory fields #2257

Unable to establish a connection with Regtest Blocktank #2259


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request A user has an idea for the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants