Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Prevent user from buying channel when node capacity is reached #1563

Closed
pwltr opened this issue Feb 13, 2024 · 8 comments · Fixed by #1618, #1946 or #2246
Closed

[Bug]: Prevent user from buying channel when node capacity is reached #1563

pwltr opened this issue Feb 13, 2024 · 8 comments · Fixed by #1618, #1946 or #2246
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pwltr
Copy link
Collaborator

pwltr commented Feb 13, 2024

Describe the bug

If the node has reached it's (legal) upper limit for capacity the LSP will throw an error like:

Channel open failed. {"message": "Node capacity is above our capacity limit. Contact us for more information.", "type": "CHANNEL_REJECTED_BY_LSP", "detail": {}, "name": "ChannelOpenError", "grenacheCall": {"workerName": "blocktank-lsp-ln2", "method": "orderChannel", "args":["<nodeId>", true, 1141097, {"pushBalanceSat": 1234567, "lspNodeId": "0296b2db342fcf87ea94d981757fdf4d3e545bd5cef4919f58b5d38dfdd73bf5c9", "zeroConf": false, "zeroReserve": true}], "options": {"timeoutMs":60000}}}

Bitkit should do some checks and prevent the user from buying addtional (large) channels.

Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots / Recording

No response

Operating system

Android, iOS

Bitkit version

master

Log output

No response

@pwltr pwltr added the bug Something isn't working label Feb 13, 2024
@JeanlChristophe
Copy link

We need a UI for that in order to explain to the user that he has hit his limits. @aldertnl

@JeanlChristophe JeanlChristophe added this to the v.1 milestone Feb 23, 2024
@pwltr pwltr self-assigned this Mar 5, 2024
@pwltr pwltr mentioned this issue Mar 26, 2024
7 tasks
@catch-21
Copy link
Contributor

@pwltr and I have discussed some edge cases in this area that need revising.

@catch-21
Copy link
Contributor

catch-21 commented May 8, 2024

Checked Transfer Funds Quick Setup slider view but still todo: Quick Setup manual input and Advanced flows.

@catch-21
Copy link
Contributor

catch-21 commented May 8, 2024

Tested on 2c5b077
Looks good for the two Quick Setup flows (slider and manual entry) but the Advnaced flow show invalid options and proceeding results in one of two errors being displayed:

@catch-21
Copy link
Contributor

catch-21 commented Jul 2, 2024

Tested on v128 e8f5056
I currently have one LN connection with Blocktank with 656_069 and one with LNBig for 192_020 receiving capacity (853_089 total = €491.99). When I go to transfer funds I am limisted to 40_196 sats receiving capacity (€515). This doesn't seem like enough, shouldn't I be allowed a lot more, up to near €999?

Screenrecorder-2024-07-02-17-36-56-103.mp4

@catch-21 catch-21 reopened this Jul 2, 2024
@pwltr
Copy link
Collaborator Author

pwltr commented Jul 9, 2024

The limit is about total channel size not receiving capacity only. That said it should only apply to Blocktank channels so there is a todo here.

@pwltr
Copy link
Collaborator Author

pwltr commented Sep 10, 2024

This needs to be worked on together with #1972

@pwltr pwltr linked a pull request Sep 25, 2024 that will close this issue
7 tasks
@catch-21
Copy link
Contributor

catch-21 commented Dec 24, 2024

This area has been reworked and I cannot reproduce this issue in v1.0.8.
It is possible to get close to 950 euro total capacity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment