Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: channel UI fixes #1618

Merged
merged 3 commits into from
Mar 27, 2024
Merged

fix: channel UI fixes #1618

merged 3 commits into from
Mar 27, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Mar 26, 2024 •
edited
Loading

Description

  • QuickSetup/Transfer: prevent buying channel when node capacity is reached
  • ChannelList: show stuck pending channels
  • CustomSetup: use maximum channel duration from LSP api
  • CustomSetup: Remove 'Custom Amount' button for receiving capacity screen
  • some renaming for clarity

Linked Issues/Tasks

Closes #1563

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-03-26.at.15.11.27.mp4

QA Notes

  1. Buy a CJIT channel to get maximum inbound capacity
  2. Try to buy another channel via transfer flow
  3. The UI should prevent you from buying the channel

@pwltr pwltr force-pushed the fix/channel-fixes branch from 3349da8 to 18cef59 Compare March 26, 2024 16:37
@pwltr pwltr requested a review from coreyphillips March 26, 2024 16:38
@pwltr pwltr force-pushed the fix/channel-fixes branch from 18cef59 to fe4c153 Compare March 27, 2024 19:09
@pwltr pwltr merged commit 53bdc25 into master Mar 27, 2024
4 checks passed
@pwltr pwltr deleted the fix/channel-fixes branch March 27, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Prevent user from buying channel when node capacity is reached
2 participants
@pwltr @coreyphillips