Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Advanced Manual Setup does not require Host and Port #2257

Closed
catch-21 opened this issue Sep 30, 2024 · 1 comment · Fixed by #2265
Closed

[Bug]: Advanced Manual Setup does not require Host and Port #2257

catch-21 opened this issue Sep 30, 2024 · 1 comment · Fixed by #2265
Assignees
@pwltr
Labels
bug Something isn't working

Comments

@catch-21
Copy link
Contributor

catch-21 commented Sep 30, 2024 •
edited
Loading

Describe the bug

The Manual Setup page requires Node ID but does not require Host and Port to proceed and swipe to pay.

Reproduce

  1. Go to Advanced settings -> Lightning Connections -> Add Connection
  2. Input valid Node ID only, do not enter ip or port
  3. Tap Continue
  4. Swipe to Transfer
  5. Observe inevitable error that could be caught earlier with form validation on mandatory field (all are mandatory)

Screenshots / Recording

Screenshot 2024-09-30 at 11 01 34

Operating system

Android 14

Bitkit version

1.0.5 (136)

Log output

No response
@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels Sep 30, 2024
@catch-21 catch-21 mentioned this issue Sep 30, 2024
Closed
@pwltr pwltr self-assigned this Sep 30, 2024
@pwltr pwltr removed the triage This issue needs to be looked over by the team label Sep 30, 2024
@pwltr pwltr mentioned this issue Sep 30, 2024
Merged
7 tasks
@pwltr pwltr linked a pull request Sep 30, 2024 that will close this issue
fix: external channel UI #2265
Merged
7 tasks
@catch-21
Copy link
Contributor Author

catch-21 commented Oct 4, 2024

Verified in 0d67faa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwltr pwltr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: external channel UI synonymdev/bitkit
2 participants
@pwltr @catch-21