-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update moonbeam assets for constants / sdk #3376
Conversation
WalkthroughThe changes in this pull request involve updates to the image URLs and color properties for the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (2)packages/synapse-constants/src/constants/tokens/bridgeable.ts (2)
The logo URLs for both MOVR and WMOVR tokens have been updated to use a new domain ('adf1cceb'). Also applies to: 820-820 ✅ Verification successfulLogo URL domain update appears consistent The new domain
The color change to 'lime' is also consistent with other tokens and chains in the codebase, including USDT, JEWEL, and various chain configurations. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if the new domain is used consistently across the codebase
echo "Checking for old domain usage..."
rg "8f3ea9f2.sanguine-fe.pages.dev" -l
echo "Checking for new domain usage..."
rg "adf1cceb.sanguine-fe.pages.dev" -l
Length of output: 17872
The color property for both MOVR and WMOVR tokens has been changed from 'purple' to 'lime'. Ensure this change aligns with the UI design system and maintains visual consistency. Also applies to: 822-822 ✅ Verification successfulLet me generate additional scripts to check for color usage patterns and design system references. Color change is part of a broader UI color scheme update Based on the git history and codebase analysis, the color change from 'purple' to 'lime' for MOVR and WMOVR tokens is part of a consistent pattern where:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check for other tokens using 'lime' color to ensure consistency
echo "Checking other tokens using 'lime' color..."
rg "color: 'lime'" -B 2 -A 2
Length of output: 17872 Script: #!/bin/bash
# Check for any color-related constants or theme definitions
echo "Checking for color/theme definitions..."
rg -i "theme|color.*lime|color.*purple" --type ts -g "theme*" -g "style*" -g "color*"
# Check for previous color value
echo "Checking for purple color usage..."
rg "color: 'purple'" -B 2 -A 2
# Check commit history for color-related changes
echo "Checking recent color-related changes..."
git log -p --grep="color" -i -- "*.ts" "*.tsx" | grep -A 5 -B 5 "color.*lime\|color.*purple"
Length of output: 21299 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Deploying sanguine-fe with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3376 +/- ##
=============================================
Coverage 90.44834% 90.44834%
=============================================
Files 54 54
Lines 1026 1026
Branches 82 82
=============================================
Hits 928 928
Misses 95 95
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 200.06kB (0.62%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Summary by CodeRabbit
MOONBEAM
andMOONRIVER
chains, improving the visual representation of these chains in the application.MOVR
andWMOVR
tokens, ensuring users see the most current images associated with these tokens.MOVR
andWMOVR
tokens (from purple to lime), enhancing their visual distinction in the application.f0a1307: synapse-interface preview link
231975b: synapse-interface preview link
1c90ed1: synapse-interface preview link
5572f88: synapse-interface preview link