Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update moonbeam assets for constants / sdk #3376

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Nov 6, 2024

Summary by CodeRabbit

  • New Features
    • Updated image URLs for the MOONBEAM and MOONRIVER chains, improving the visual representation of these chains in the application.
    • Updated logo URLs for the MOVR and WMOVR tokens, ensuring users see the most current images associated with these tokens.
    • Changed color representations for the MOVR and WMOVR tokens (from purple to lime), enhancing their visual distinction in the application.

f0a1307: synapse-interface preview link
231975b: synapse-interface preview link
1c90ed1: synapse-interface preview link
5572f88: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

Walkthrough

The changes in this pull request involve updates to the image URLs and color properties for the MOONBEAM and MOONRIVER chain constants across multiple files. The chainImg and imgUrl properties have been replaced with new URLs pointing to different resources. Additionally, the color properties for these chains have been modified. No other properties or structures within the chain constants have been altered.

Changes

File Path Change Summary
packages/synapse-constants/src/constants/chains/master.ts Updated chainImg URLs and color properties for MOONBEAM and MOONRIVER.
packages/widget/src/constants/chains.ts Updated imgUrl properties for MOONBEAM and MOONRIVER to new image locations.
packages/synapse-constants/src/constants/tokens/bridgeable.ts Updated logo URLs and color properties for MOVR and WMOVR tokens.
packages/synapse-interface/constants/chains/master.tsx Updated color properties for MOONBEAM and MOONRIVER.
packages/widget/src/constants/bridgeable.ts Updated imgUrl properties and color for MOVR and WMOVR tokens.
packages/synapse-interface/constants/tokens/bridgeable.ts Updated color properties for MOVR and WMOVR tokens.

Possibly related PRs

Suggested reviewers

  • aureliusbtc
  • trajan0x

Poem

In the land of chains so bright,
New images take their flight.
Moonbeam and River, side by side,
With fresh URLs, they now abide.
Hopping along, we cheer and play,
For brighter paths lead the way! 🐰✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 171e60a and 09c5dde.

📒 Files selected for processing (3)
  • packages/synapse-constants/src/constants/tokens/bridgeable.ts (2 hunks)
  • packages/synapse-interface/constants/tokens/bridgeable.ts (2 hunks)
  • packages/widget/src/constants/bridgeable.ts (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/constants/tokens/bridgeable.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/widget/src/constants/bridgeable.ts
🔇 Additional comments (2)
packages/synapse-constants/src/constants/tokens/bridgeable.ts (2)

783-783: Verify the new logo URL domain.

The logo URLs for both MOVR and WMOVR tokens have been updated to use a new domain ('adf1cceb').

Also applies to: 820-820

✅ Verification successful

Logo URL domain update appears consistent

The new domain adf1cceb.sanguine-fe.pages.dev is being used consistently across multiple packages:

  • packages/widget/src/constants/chains.ts
  • packages/widget/src/constants/bridgeable.ts
  • packages/synapse-constants/src/constants/tokens/bridgeable.ts
  • packages/synapse-constants/src/constants/chains/master.ts

The color change to 'lime' is also consistent with other tokens and chains in the codebase, including USDT, JEWEL, and various chain configurations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the new domain is used consistently across the codebase
echo "Checking for old domain usage..."
rg "8f3ea9f2.sanguine-fe.pages.dev" -l

echo "Checking for new domain usage..."
rg "adf1cceb.sanguine-fe.pages.dev" -l

Length of output: 17872


786-786: Verify UI impact of color changes.

The color property for both MOVR and WMOVR tokens has been changed from 'purple' to 'lime'. Ensure this change aligns with the UI design system and maintains visual consistency.

Also applies to: 822-822

✅ Verification successful

Let me generate additional scripts to check for color usage patterns and design system references.


Color change is part of a broader UI color scheme update

Based on the git history and codebase analysis, the color change from 'purple' to 'lime' for MOVR and WMOVR tokens is part of a consistent pattern where:

  • The Moonriver chain's color was also updated from 'purple' to 'lime'
  • Other tokens in the same ecosystem (JEWEL, WJEWEL, synJEWEL, xJEWEL) also use 'lime' color
  • The change appears to be part of a coordinated UI update to maintain visual consistency across related tokens and their chains
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for other tokens using 'lime' color to ensure consistency
echo "Checking other tokens using 'lime' color..."
rg "color: 'lime'" -B 2 -A 2

Length of output: 17872


Script:

#!/bin/bash
# Check for any color-related constants or theme definitions
echo "Checking for color/theme definitions..."
rg -i "theme|color.*lime|color.*purple" --type ts -g "theme*" -g "style*" -g "color*"

# Check for previous color value
echo "Checking for purple color usage..."
rg "color: 'purple'" -B 2 -A 2

# Check commit history for color-related changes
echo "Checking recent color-related changes..."
git log -p --grep="color" -i -- "*.ts" "*.tsx" | grep -A 5 -B 5 "color.*lime\|color.*purple"

Length of output: 21299


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 09c5dde
Status: ✅  Deploy successful!
Preview URL: https://a547ed2a.sanguine-fe.pages.dev
Branch Preview URL: https://constants-moonbeam.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44834%. Comparing base (038f3a6) to head (09c5dde).
Report is 3 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #3376   +/-   ##
=============================================
  Coverage   90.44834%   90.44834%           
=============================================
  Files             54          54           
  Lines           1026        1026           
  Branches          82          82           
=============================================
  Hits             928         928           
  Misses            95          95           
  Partials           3           3           
Flag Coverage Δ
packages 90.44834% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Nov 6, 2024

Bundle Report

Changes will increase total bundle size by 200.06kB (0.62%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
synapse-interface-client-array-push 7.5MB 9.08kB (0.12%) ⬆️
synapse-interface-server-cjs 1.65MB 9.09kB (0.55%) ⬆️
widget-esm-cjs 277.07kB 3.77kB (1.38%) ⬆️
@synapsecns/synapse-constants-cjs-esm 178.12kB 178.12kB (100%) ⬆️

@github-actions github-actions bot added size/s and removed size/xs labels Nov 6, 2024
@bigboydiamonds bigboydiamonds merged commit 50140bc into master Nov 7, 2024
39 checks passed
@bigboydiamonds bigboydiamonds deleted the constants/moonbeam branch November 7, 2024 09:10
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants