Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synapse-interface): METIS token #3044

Merged
merged 4 commits into from
Aug 21, 2024
Merged

feat(synapse-interface): METIS token #3044

merged 4 commits into from
Aug 21, 2024

Conversation

bigboydiamonds
Copy link
Collaborator

@bigboydiamonds bigboydiamonds commented Aug 21, 2024

Summary by CodeRabbit

  • New Features

    • Introduced multiple new bridge entries associated with the Metis network, enhancing interoperability.
    • Added support for the "Metis Token," improving token management within the application.
    • Updated currency symbol for consistency, changing 'METIS' to 'Metis'.
    • Expanded symbol mapping with a new entry for WMetis, improving cryptocurrency symbol integration.
  • Bug Fixes

    • None
  • Documentation

    • None
  • Refactor

    • None
  • Style

    • None
  • Tests

    • None
  • Chores

    • None
  • Revert

    • None

7135f02: synapse-interface preview link
36515c9: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Aug 21, 2024

Walkthrough

The recent changes enhance the bridgeMap and bridgeable token functionalities by introducing new bridge entries and a Metis token representation. This expansion particularly focuses on the Metis network, improving interoperability and token management within the application, thereby facilitating better integration of resources across the platform.

Changes

Files Change Summary
.../constants/bridgeMap.ts, .../constants/tokens/bridgeable.ts New entries added to BRIDGE_MAP for Metis bridges, enhancing connectivity. Introduction of a METIS token with defined properties, supporting multiple chains and improving token management.
.../constants/chains/master.tsx, .../scripts/data/symbolOverrides.json Updated symbol casing for nativeCurrency of Metis and added a new entry mapping for a Metis bridge in symbol overrides, enhancing consistency and functionality across the application.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant Bridge
    participant TokenManager

    User->>Application: Initiate bridge transaction
    Application->>Bridge: Verify bridge availability
    Bridge-->>Application: Confirm bridge details
    Application->>TokenManager: Retrieve token information
    TokenManager-->>Application: Provide token data
    Application->>User: Complete transaction
Loading

Poem

In fields of code, where bridges bloom,
A token hops, dispelling gloom.
With Metis grace, they leap and twirl,
Enhancing chains, a dance to unfurl.
Hooray for bridges, a joyful sight,
In the coding world, all feels just right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4fd9ef1 and 8b7cc72.

Files ignored due to path filters (2)
  • packages/synapse-interface/assets/chains/metis.svg is excluded by !**/*.svg
  • packages/synapse-interface/assets/icons/metis.svg is excluded by !**/*.svg
Files selected for processing (2)
  • packages/synapse-interface/constants/bridgeMap.ts (4 hunks)
  • packages/synapse-interface/constants/tokens/bridgeable.ts (2 hunks)
Additional comments not posted (6)
packages/synapse-interface/constants/tokens/bridgeable.ts (2)

22-22: Import statement approved.

The import statement for metisLogo is consistent with other logo imports.


1214-1232: METIS token definition approved.

The METIS token is correctly defined with all necessary properties and is consistent with other token definitions.

packages/synapse-interface/constants/bridgeMap.ts (4)

897-903: Bridge entry for WMETIS approved.

The entry is correctly defined with all necessary attributes and is consistent with other bridge entries.


932-938: Bridge entry for METIS approved.

The entry is correctly defined with all necessary attributes and is consistent with other bridge entries.


1196-1202: Bridge entry for Metis approved.

The entry is correctly defined with all necessary attributes and is consistent with other bridge entries.


1760-1766: Bridge entry for Metis approved.

The entry is correctly defined with all necessary attributes and is consistent with other bridge entries.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.27567%. Comparing base (4fd9ef1) to head (3ec47eb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #3044         +/-   ##
===================================================
+ Coverage   23.28802%   25.27567%   +1.98765%     
===================================================
  Files            193         173         -20     
  Lines          11697       10429       -1268     
  Branches          82          82                 
===================================================
- Hits            2724        2636         -88     
+ Misses          8722        7545       -1177     
+ Partials         251         248          -3     
Flag Coverage Δ
packages 90.55118% <ø> (ø)
promexporter ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Aug 21, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ec47eb
Status: ✅  Deploy successful!
Preview URL: https://7bdf4de3.sanguine-fe.pages.dev
Branch Preview URL: https://fe-metis-token.sanguine-fe.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8b7cc72 and 3ec47eb.

Files selected for processing (4)
  • packages/synapse-interface/constants/bridgeMap.ts (4 hunks)
  • packages/synapse-interface/constants/chains/master.tsx (1 hunks)
  • packages/synapse-interface/constants/tokens/bridgeable.ts (2 hunks)
  • packages/synapse-interface/scripts/data/symbolOverrides.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/constants/chains/master.tsx
Files skipped from review as they are similar to previous changes (2)
  • packages/synapse-interface/constants/bridgeMap.ts
  • packages/synapse-interface/constants/tokens/bridgeable.ts
Additional comments not posted (1)
packages/synapse-interface/scripts/data/symbolOverrides.json (1)

14-15: New entry for "1088" is correctly added.

The addition of the "1088" entry with the address-symbol mapping is consistent with the existing JSON structure and enhances the application's functionality.

Copy link

Deploying sanguine with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ec47eb
Status: ✅  Deploy successful!
Preview URL: https://310bea24.sanguine.pages.dev
Branch Preview URL: https://fe-metis-token.sanguine.pages.dev

View logs

@bigboydiamonds bigboydiamonds merged commit d73373b into master Aug 21, 2024
38 checks passed
@bigboydiamonds bigboydiamonds deleted the fe/metis-token branch August 21, 2024 18:33
@coderabbitai coderabbitai bot mentioned this pull request Oct 4, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants