-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(synapse-interface): Fixes explorer link #2885
Conversation
WalkthroughThe recent updates primarily involve changes to documentation and a minor modification to a URL. The README.md for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Clarified that the page auto-updates as you edit and save the file in
packages/synapse-interface/README.md
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/synapse-interface/README.md (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/synapse-interface/README.md
Deploying sanguine-fe with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2885 +/- ##
===================================================
- Coverage 24.40041% 24.24166% -0.15876%
===================================================
Files 617 613 -4
Lines 47491 47373 -118
Branches 119 80 -39
===================================================
- Hits 11588 11484 -104
+ Misses 34752 34738 -14
Partials 1151 1151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Updated Ethereum explorer URL in
packages/synapse-interface/constants/chains/master.tsx
fromhttps://etherscan.com
tohttps://etherscan.io
No major changes found since last review.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/synapse-interface/constants/chains/master.tsx (1)
46-46
: Inconsistent Ethereum explorer URL update.The old URL 'etherscan.com' is still present in the following files:
packages/widget/src/constants/explorer.ts
: Line 1packages/widget/src/constants/chains.ts
: Line 1Please update these instances to 'etherscan.io' to ensure consistency across the codebase.
Analysis chain
Corrected Ethereum explorer URL.
The update from 'etherscan.com' to 'etherscan.io' is accurate and reflects the proper domain for Ethereum's block explorer.
Please ensure that this updated URL is consistently used wherever Ethereum transactions need to be explored.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the updated explorer URL is used consistently. # Test: Search for the old URL to ensure it's no longer used. rg --type tsx 'etherscan.com'Length of output: 57
Script:
#!/bin/bash # Description: Verify that the updated explorer URL is used consistently. # Test: Define the tsx file type and search for the old URL to ensure it's no longer used. rg --type-add 'tsx:*.tsx' 'etherscan.com'Length of output: 193
Bundle ReportChanges will decrease total bundle size by 131.53kB ⬇️
|
Deploying sanguine with Cloudflare Pages
|
Summary by CodeRabbit
Documentation
synapse-interface
package to clarify auto-update behavior.Bug Fixes
explorerUrl
for the Ethereum (ETH) chain from'https://etherscan.com'
to'https://etherscan.io'
.b5c4c93: synapse-interface preview link
8b9f6ea: synapse-interface preview link