Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synapse-interface): Fixes explorer link #2885

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix(synapse-interface): Fixes explorer link #2885

merged 2 commits into from
Jul 17, 2024

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Jul 17, 2024

Summary by CodeRabbit

  • Documentation

    • Updated the instruction text in the README for the synapse-interface package to clarify auto-update behavior.
  • Bug Fixes

    • Corrected the explorerUrl for the Ethereum (ETH) chain from 'https://etherscan.com' to 'https://etherscan.io'.

b5c4c93: synapse-interface preview link
8b9f6ea: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Jul 17, 2024

Walkthrough

The recent updates primarily involve changes to documentation and a minor modification to a URL. The README.md for the synapse-interface package is updated to clarify the auto-update behavior during edits. Additionally, the Ethereum explorer URL is corrected from etherscan.com to etherscan.io. These changes enhance user guidance and ensure accurate references for Ethereum transaction exploration.

Changes

File Path Change Summary
.../synapse-interface/README.md Updated instruction text to clarify auto-update behavior during edits and saves.
.../synapse-interface/constants/chains/master.tsx Updated explorerUrl for the ETH chain from 'https://etherscan.com' to 'https://etherscan.io'.

Poem

In the land of code, updates flow,
README's clarity starts to show.
URLs fixed, no more mistake,
To etherscan.io, we now partake.
With each small change, the path refines,
In the world of bytes and lines.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Clarified that the page auto-updates as you edit and save the file in packages/synapse-interface/README.md

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1ef950a and e251525.

Files selected for processing (1)
  • packages/synapse-interface/README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/synapse-interface/README.md

Copy link

cloudflare-workers-and-pages bot commented Jul 17, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6e12ebf
Status: ✅  Deploy successful!
Preview URL: https://ab1fbc16.sanguine-fe.pages.dev
Branch Preview URL: https://fe-test.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.24166%. Comparing base (1ef950a) to head (6e12ebf).

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2885         +/-   ##
===================================================
- Coverage   24.40041%   24.24166%   -0.15876%     
===================================================
  Files            617         613          -4     
  Lines          47491       47373        -118     
  Branches         119          80         -39     
===================================================
- Hits           11588       11484        -104     
+ Misses         34752       34738         -14     
  Partials        1151        1151                 
Flag Coverage Δ
packages 90.47619% <ø> (ø)
solidity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Updated Ethereum explorer URL in packages/synapse-interface/constants/chains/master.tsx from https://etherscan.com to https://etherscan.io

No major changes found since last review.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
packages/synapse-interface/constants/chains/master.tsx (1)

46-46: Inconsistent Ethereum explorer URL update.

The old URL 'etherscan.com' is still present in the following files:

  • packages/widget/src/constants/explorer.ts: Line 1
  • packages/widget/src/constants/chains.ts: Line 1

Please update these instances to 'etherscan.io' to ensure consistency across the codebase.

Analysis chain

Corrected Ethereum explorer URL.

The update from 'etherscan.com' to 'etherscan.io' is accurate and reflects the proper domain for Ethereum's block explorer.

Please ensure that this updated URL is consistently used wherever Ethereum transactions need to be explored.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the updated explorer URL is used consistently.

# Test: Search for the old URL to ensure it's no longer used.
rg --type tsx 'etherscan.com'

Length of output: 57


Script:

#!/bin/bash
# Description: Verify that the updated explorer URL is used consistently.

# Test: Define the tsx file type and search for the old URL to ensure it's no longer used.
rg --type-add 'tsx:*.tsx' 'etherscan.com'

Length of output: 193

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e251525 and 6e12ebf.

Files selected for processing (1)
  • packages/synapse-interface/constants/chains/master.tsx (1 hunks)

@abtestingalpha abtestingalpha changed the title Test edit readme fix(synapse-interface): Fixes explorer link Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Bundle Report

Changes will decrease total bundle size by 131.53kB ⬇️

Bundle name Size Change
sdk-router-@synapsecns/sdk-router-esm 252.15kB 0 bytes
sdk-router-@synapsecns/sdk-router-cjs 116.93kB 404.83kB ⬇️
synapse-interface-server-cjs 1.38MB 0 bytes
synapse-interface-edge-server-array-push 83 bytes 0 bytes
synapse-interface-client-array-push 7.45MB 1 bytes ⬇️
widget-cjs-esm 273.3kB 273.3kB ⬆️
widget-esm-cjs 275.25kB 0 bytes

Copy link

Deploying sanguine with  Cloudflare Pages  Cloudflare Pages

Latest commit: e251525
Status: ✅  Deploy successful!
Preview URL: https://ac945f2d.sanguine.pages.dev
Branch Preview URL: https://fe-test.sanguine.pages.dev

View logs

@abtestingalpha abtestingalpha merged commit a9c1073 into master Jul 17, 2024
38 checks passed
@abtestingalpha abtestingalpha deleted the fe/test branch July 17, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant