Temporarily remove the global min(a,b) and max(a,b) SIMD functions. #23960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
stephentyrone
force-pushed
the
minimal-revert
branch
from
26184a0 to
300af21
Compare
These are triggering a bad compile-time regression for some expressions; that's a bug that should be fixed, but we don't know how to fix it yet, so we'll need to remove these in the short-term, and possibly spell them differently in the medium term.
stephentyrone
force-pushed
the
minimal-revert
branch
from
300af21 to
2304bd2
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
1 similar comment
|
@swift-ci please smoke test linux |
stephentyrone
added a commit
to stephentyrone/swift
that referenced
this pull request
Apr 12, 2019
…wiftlang#23960) These are triggering a bad compile-time regression for some expressions; that's a bug that should be fixed, but we don't know how to fix it yet, so we'll need to remove these in the short-term, and possibly spell them differently in the medium term.
stephentyrone
added a commit
that referenced
this pull request
Apr 16, 2019
* Some cleanup of SIMDVector and SIMDVectorTypes source files. (#23389) Bring formatting closer in line with the rest of the standard lib, remove "public" from extensions (moving it onto the contents defined therein). Restore Swift project headers that were apparently lost at some point. * [SE-0251] Additions to SIMD types. (#23421) * Additions to SIMD types. - extension from 2 and 3-element vectors to 3- and 4-element vectors. - the .one member - swizzles via subscript-by-simd - min/max/sum reductions - min/max/clamp on vectors-of-comparable - any and all - Make permute subscript wrap on vector length, even for SIMD3 dictionaries. Also restore min/max to globals, rather than static functions. * Temporarily remove the global min(a,b) and max(a,b) SIMD functions. (#23960) These are triggering a bad compile-time regression for some expressions; that's a bug that should be fixed, but we don't know how to fix it yet, so we'll need to remove these in the short-term, and possibly spell them differently in the medium term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are triggering a bad compile-time regression for some expressions; that's a bug that should be fixed, but we don't know how to fix it yet, so we'll need to remove these in the short-term, and possibly spell them differently in the medium term.
rdar://problem/49787922