Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove the global min(a,b) and max(a,b) SIMD functions. #23960

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Temporarily remove the global min(a,b) and max(a,b) SIMD functions. #23960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion stdlib/public/core/SIMDVector.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,15 +467,17 @@ extension SIMD where Scalar: Comparable {
return lhs .> Self(repeating: rhs)
}

/* Temporarily removed pending plan for Swift.min / Swift.max
@_alwaysEmitIntoClient
public mutating func clamp(lowerBound: Self, upperBound: Self) {
self = self.clamped(lowerBound: lowerBound, upperBound: upperBound)
}

@_alwaysEmitIntoClient
public func clamped(lowerBound: Self, upperBound: Self) -> Self {
return Swift.min(upperBound, Swift.max(lowerBound, self))
}
*/
}

extension SIMD where Scalar: FixedWidthInteger {
Expand Down Expand Up @@ -1341,6 +1343,10 @@ public func all<Storage>(_ mask: SIMDMask<Storage>) -> Bool {
return mask._storage.max() < 0
}

/*
Temporarily removed while we investigate compile-time regressions caused by
introducing these global functions.

/// The lanewise minimum of two vectors.
///
/// Each element of the result is the minimum of the corresponding elements
Expand Down Expand Up @@ -1397,3 +1403,4 @@ where V: SIMD, V.Scalar: FloatingPoint {
}
return result
}
*/