Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Implement SE-0251 #23940

Merged

Conversation

stephentyrone
Copy link
Contributor

Includes:

Addresses rdar://problem/48276450

…ng#23389)

Bring formatting closer in line with the rest of the standard lib, remove "public" from extensions (moving it onto the contents defined therein). Restore Swift project headers that were apparently lost at some point.
* Additions to SIMD types.

- extension from 2 and 3-element vectors to 3- and 4-element vectors.
- the .one member
- swizzles via subscript-by-simd
- min/max/sum reductions
- min/max/clamp on vectors-of-comparable
- any and all

- Make permute subscript wrap on vector length, even for SIMD3 dictionaries. Also restore min/max to globals, rather than static functions.
@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@stephentyrone
Copy link
Contributor Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 114e9ce

@stephentyrone
Copy link
Contributor Author

@swift-ci please test linux

@stephentyrone
Copy link
Contributor Author

This will need to pickup #23960 before landing, but I'll get that onto master first.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 114e9ce

…wiftlang#23960)

These are triggering a bad compile-time regression for some expressions; that's a bug that should be fixed, but we don't know how to fix it yet, so we'll need to remove these in the short-term, and possibly spell them differently in the medium term.
@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@stephentyrone
Copy link
Contributor Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 114e9ce

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 114e9ce

@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 50d74a0

@stephentyrone
Copy link
Contributor Author

@swift-ci please test macOS

@stephentyrone stephentyrone merged commit 3f96b5f into swiftlang:swift-5.1-branch Apr 16, 2019
@stephentyrone stephentyrone deleted the simd-additions-5.1 branch April 16, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants