-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lib CallbackUtils & Remove PoolNFT callback try/catch #1979
Conversation
hellwolf
commented
Jul 2, 2024
•
edited
Loading
edited
- CallbackUtils replaces SafeGasLibrary.
- Remove try/catch in PoolNFT callbacks.
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1979 +/- ##
==========================================
+ Coverage 88.53% 88.62% +0.09%
==========================================
Files 119 119
Lines 7389 7387 -2
Branches 977 980 +3
==========================================
+ Hits 6542 6547 +5
+ Misses 845 838 -7
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I was most concerned about poolMemberNFT.onDelete
failing if minting hadn't succeeded. But that's safe because if not minted, poolMemberNFT.poolMemberDataByTokenId(tokenId).member
will be the zero address.
This way we get rid of the issue of try/catch misleading the gas estimation, leading to failed transactions.
This PR also fixes the failing test in #1982 (I tried locally).
XKCD Comic RelifLink: https://xkcd.com/1979 |